diff mbox series

[libgpiod] bindings: cxx: tests: set direction when reconfiguring lines

Message ID 20240708094827.84986-1-brgl@bgdev.pl
State New
Headers show
Series [libgpiod] bindings: cxx: tests: set direction when reconfiguring lines | expand

Commit Message

Bartosz Golaszewski July 8, 2024, 9:48 a.m. UTC 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Linux kernel commit b44039638741 ("gpiolib: cdev: Ignore reconfiguration
without direction") made the direction setting mandatory for line config
passed to the kernel when reconfiguring requested lines. Fix the C++ test
case which doesn't do it and now fails due to the rest of the settings
being ignored.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 bindings/cxx/tests/tests-line-request.cpp | 1 +
 1 file changed, 1 insertion(+)

Comments

Kent Gibson July 8, 2024, 10 a.m. UTC | #1 
On Mon, Jul 08, 2024 at 11:48:27AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> Linux kernel commit b44039638741 ("gpiolib: cdev: Ignore reconfiguration
> without direction") made the direction setting mandatory for line config
> passed to the kernel when reconfiguring requested lines. Fix the C++ test
> case which doesn't do it and now fails due to the rest of the settings
> being ignored.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  bindings/cxx/tests/tests-line-request.cpp | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/bindings/cxx/tests/tests-line-request.cpp b/bindings/cxx/tests/tests-line-request.cpp
> index af8b979..a99bd44 100644
> --- a/bindings/cxx/tests/tests-line-request.cpp
> +++ b/bindings/cxx/tests/tests-line-request.cpp
> @@ -208,6 +208,7 @@ TEST_CASE("values can be read", "[line-request]")
>  				.add_line_settings(
>  					offs,
>  					::gpiod::line_settings()
> +						.set_direction(direction::INPUT)
>  						.set_active_low(true))
>  		);
>

My bad - I hadn't tried the C++ or Rust tests with that patch, or I
would've patched these myself.

Reviewed-by: Kent Gibson <warthog618@gmail.com>

for both C++ and Rust.
Bartosz Golaszewski July 8, 2024, 6:53 p.m. UTC | #2 
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>


On Mon, 08 Jul 2024 11:48:27 +0200, Bartosz Golaszewski wrote:
> Linux kernel commit b44039638741 ("gpiolib: cdev: Ignore reconfiguration
> without direction") made the direction setting mandatory for line config
> passed to the kernel when reconfiguring requested lines. Fix the C++ test
> case which doesn't do it and now fails due to the rest of the settings
> being ignored.
> 
> 
> [...]

Applied, thanks!

[1/1] bindings: cxx: tests: set direction when reconfiguring lines
      commit: 3e224d885b1de54fe5510b9c5e7296260a1a4507

Best regards,
diff mbox series

Patch

diff --git a/bindings/cxx/tests/tests-line-request.cpp b/bindings/cxx/tests/tests-line-request.cpp
index af8b979..a99bd44 100644
--- a/bindings/cxx/tests/tests-line-request.cpp
+++ b/bindings/cxx/tests/tests-line-request.cpp
@@ -208,6 +208,7 @@  TEST_CASE("values can be read", "[line-request]")
 				.add_line_settings(
 					offs,
 					::gpiod::line_settings()
+						.set_direction(direction::INPUT)
 						.set_active_low(true))
 		);