diff mbox series

[BlueZ,v1] shared/shell: add return value check of io_get_fd() to input_read()

Message ID 20240702140313.107131-1-r.smirnov@omp.ru
State New
Headers show
Series [BlueZ,v1] shared/shell: add return value check of io_get_fd() to input_read() | expand

Commit Message

Roman Smirnov July 2, 2024, 2:03 p.m. UTC
It is necessary to add a return value check.

Found with the SVACE static analysis tool.
---
 src/shared/shell.c | 5 +++++
 1 file changed, 5 insertions(+)
diff mbox series

Patch

diff --git a/src/shared/shell.c b/src/shared/shell.c
index 2ecc41bf3..add4fa131 100644
--- a/src/shared/shell.c
+++ b/src/shared/shell.c
@@ -289,6 +289,11 @@  static bool input_read(struct io *io, void *user_data)
 
 	fd = io_get_fd(io);
 
+	if (fd < 0) {
+		printf("io_get_fd() returned %d\n", fd);
+		return false;
+	}
+
 	if (fd == STDIN_FILENO) {
 		rl_callback_read_char();
 		return true;