diff mbox series

[BlueZ,v1] core/gatt: add return value check of io_get_fd() to sock_read()

Message ID 20240702125157.87719-1-r.smirnov@omp.ru
State New
Headers show
Series [BlueZ,v1] core/gatt: add return value check of io_get_fd() to sock_read() | expand

Commit Message

Roman Smirnov July 2, 2024, 12:51 p.m. UTC 
It is necessary to add a return value check.

Found with the SVACE static analysis tool.
---
 src/gatt-client.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

patchwork-bot+bluetooth@kernel.org July 3, 2024, 3:10 p.m. UTC | #1 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 2 Jul 2024 15:51:57 +0300 you wrote:
> It is necessary to add a return value check.
> 
> Found with the SVACE static analysis tool.
> ---
>  src/gatt-client.c | 5 +++++
>  1 file changed, 5 insertions(+)

Here is the summary with links:
  - [BlueZ,v1] core/gatt: add return value check of io_get_fd() to sock_read()
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=605e078556d0

You are awesome, thank you!
diff mbox series

Patch

diff --git a/src/gatt-client.c b/src/gatt-client.c
index 60a21e3f6..8d83a9577 100644
--- a/src/gatt-client.c
+++ b/src/gatt-client.c
@@ -1127,6 +1127,11 @@  static bool sock_read(struct io *io, void *user_data)
 	msg.msg_iov = &iov;
 	msg.msg_iovlen = 1;
 
+	if (fd < 0) {
+		error("io_get_fd() returned %d\n", fd);
+		return false;
+	}
+
 	bytes_read = recvmsg(fd, &msg, MSG_DONTWAIT);
 	if (bytes_read < 0) {
 		error("recvmsg: %s", strerror(errno));