| Message ID | 20240630-oneplus8-v2-1-c4a1f8da74f1@postmarketos.org |
|---|---|
| State | New |
| Headers | show |
| Series | qcom: initial support for the OnePlus 8T | expand |
On Sun, 30 Jun 2024 20:36:24 +0200, Caleb Connolly wrote: > Describe the Samsung AMB655X panel. It has three supplies. > > Signed-off-by: Caleb Connolly <caleb@postmarketos.org> > --- > .../bindings/display/panel/samsung,amb655x.yaml | 63 ++++++++++++++++++++++ > 1 file changed, 63 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dts:20.11-21: Warning (reg_format): /example-0/panel@0:reg: property has invalid length (4 bytes) (#address-cells == 1, #size-cells == 1) Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/display/panel/samsung,amb655x.example.dtb: Warning (spi_bus_reg): Failed prerequisite 'reg_format' doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240630-oneplus8-v2-1-c4a1f8da74f1@postmarketos.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,amb655x.yaml b/Documentation/devicetree/bindings/display/panel/samsung,amb655x.yaml new file mode 100644 index 000000000000..085ad02ac74f --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/samsung,amb655x.yaml @@ -0,0 +1,63 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/samsung,amb655x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung AMB655X 1080x2400 120hz AMOLED panel + +maintainers: + - Caleb Connolly <caleb@postmarketos.org> + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: samsung,amb655x + + reg: + maxItems: 1 + + reset-gpios: + description: reset gpio, must be GPIO_ACTIVE_LOW + + vddio-supply: true + vdd-supply: true + avdd-supply: true + enable-gpios: true + port: true + +required: + - compatible + - reg + - vdd-supply + - avdd-supply + - vddio-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + panel@0 { + reg = <0>; + compatible = "samsung,amb655x"; + vddio-supply = <&vreg_l14a_1p8>; + vdd-supply = <&vreg_l11c_3p3>; + avdd-supply = <&panel_avdd_5p5>; + reset-gpios = <&tlmm 75 GPIO_ACTIVE_LOW>; + + pinctrl-0 = <&panel_reset_pins &panel_vsync_pins &panel_vout_pins>; + pinctrl-names = "default"; + + status = "okay"; + + port { + panel_in_0: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; + +...
Describe the Samsung AMB655X panel. It has three supplies. Signed-off-by: Caleb Connolly <caleb@postmarketos.org> --- .../bindings/display/panel/samsung,amb655x.yaml | 63 ++++++++++++++++++++++ 1 file changed, 63 insertions(+)