diff mbox series

MIPS: crypto: Clean up useless assignment operations

Message ID 1D248893502B75F5+20240628084117.84264-1-wangyuli@uniontech.com
State New
Headers show
Series MIPS: crypto: Clean up useless assignment operations | expand

Commit Message

WangYuli June 28, 2024, 8:41 a.m. UTC 
When entering the "len & sizeof(u32)" branch, len must be less than 8.
So after one operation, len must be less than 4.
At this time, "len -= sizeof(u32)" is not necessary for 64-bit CPUs.

A similar issue has been solved at Loongarch.

Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v6.10-rc5&id=fea1c949f6ca5059e12de00d0483645debc5b206
Signed-off-by: Guan Wentao <guanwentao@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/crypto/crc32-mips.c | 4 ++++
 1 file changed, 4 insertions(+)
diff mbox series

Patch

diff --git a/arch/mips/crypto/crc32-mips.c b/arch/mips/crypto/crc32-mips.c
index ec6d58008f8e..505d2d897849 100644
--- a/arch/mips/crypto/crc32-mips.c
+++ b/arch/mips/crypto/crc32-mips.c
@@ -94,7 +94,9 @@  static u32 crc32_mips_le_hw(u32 crc_, const u8 *p, unsigned int len)
 
 		CRC32(crc, value, w);
 		p += sizeof(u32);
+#ifndef CONFIG_64BIT
 		len -= sizeof(u32);
+#endif
 	}
 
 	if (len & sizeof(u16)) {
@@ -134,7 +136,9 @@  static u32 crc32c_mips_le_hw(u32 crc_, const u8 *p, unsigned int len)
 
 		CRC32C(crc, value, w);
 		p += sizeof(u32);
+#ifndef CONFIG_64BIT
 		len -= sizeof(u32);
+#endif
 	}
 
 	if (len & sizeof(u16)) {