diff mbox series

[v2,02/10] dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names

Message ID 20240628-cleanup-ad7606-v2-2-96e02f90256d@baylibre.com
State New
Headers show
Series iio: adc: ad7606: Improvements | expand

Commit Message

Guillaume Stols June 28, 2024, 2:48 p.m. UTC
AD7606-8 is referred to as AD7606 by Analog Devices. This comment aims
to avoid confusion. Also the compatible names were not sorted by
alphabetical order.

Signed-off-by: Guillaume Stols <gstols@baylibre.com>
---
 Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jonathan Cameron June 29, 2024, 3:22 p.m. UTC | #1
On Fri, 28 Jun 2024 14:48:20 +0000
Guillaume Stols <gstols@baylibre.com> wrote:

> AD7606-8 is referred to as AD7606 by Analog Devices. This comment aims
> to avoid confusion. Also the compatible names were not sorted by
> alphabetical order.
> 
> Signed-off-by: Guillaume Stols <gstols@baylibre.com>

So b4 interestingly picked up both acks from Rob and Conor on this
one but I can't figure out where Conor's one came from so I've dropped
it.

Applied.

> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> index d55c58400df5..00fdaed11cbd 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
> @@ -20,9 +20,9 @@ properties:
>    compatible:
>      enum:
>        - adi,ad7605-4
> -      - adi,ad7606-8
> -      - adi,ad7606-6
>        - adi,ad7606-4
> +      - adi,ad7606-6
> +      - adi,ad7606-8  # Referred to as AD7606 (without -8) in the datasheet
>        - adi,ad7606b
>        - adi,ad7616
>  
>
Conor Dooley June 30, 2024, 2 p.m. UTC | #2
On Sat, Jun 29, 2024 at 04:22:23PM +0100, Jonathan Cameron wrote:
> On Fri, 28 Jun 2024 14:48:20 +0000
> Guillaume Stols <gstols@baylibre.com> wrote:
> 
> > AD7606-8 is referred to as AD7606 by Analog Devices. This comment aims
> > to avoid confusion. Also the compatible names were not sorted by
> > alphabetical order.
> > 
> > Signed-off-by: Guillaume Stols <gstols@baylibre.com>
> 
> So b4 interestingly picked up both acks from Rob and Conor on this
> one but I can't figure out where Conor's one came from so I've dropped
> it.

My copy of b4 (0.14-dev-d4707) doesn't create one for me:
/stuff/b4/b4.sh shazam -s -S -t shazam 20240628-cleanup-ad7606-v2-2-96e02f90256d@baylibre.com
Grabbing thread from lore.kernel.org/all/20240628-cleanup-ad7606-v2-2-96e02f90256d@baylibre.com/t.mbox.gz
Checking for newer revisions
Grabbing search results from lore.kernel.org
Analyzing 20 messages in the thread
Looking for additional code-review trailers on lore.kernel.org
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v2 1/10] dt-bindings: iio: adc: adi,ad7606: add missing datasheet link
    + Acked-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ✓ [PATCH v2 2/10] dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names
    + Acked-by: Rob Herring (Arm) <robh@kernel.org> (✓ DKIM/kernel.org)
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ✓ [PATCH v2 3/10] dt-bindings: iio: adc: adi,ad7606: normalize textwidth
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ✓ [PATCH v2 4/10] dt-bindings: iio: adc: adi,ad7606: improve descriptions
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ✓ [PATCH v2 5/10] dt-bindings: iio: adc: adi,ad7606: add supply properties
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ✓ [PATCH v2 6/10] dt-bindings: iio: adc: adi,ad7606: fix example
    + Acked-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ✓ [PATCH v2 7/10] dt-bindings: iio: adc: adi,ad7606: add conditions
    + Reviewed-by: Conor Dooley <conor.dooley@microchip.com> (✓ DKIM/kernel.org)
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ✓ [PATCH v2 8/10] iio: adc: ad7606: fix oversampling gpio array
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ✓ [PATCH v2 9/10] iio: adc: ad7606: fix standby gpio state to match the documentation
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ✓ [PATCH v2 10/10] iio: adc: ad7606: switch mutexes to scoped_guard
    + Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
  ---
  ✓ Signed: DKIM/baylibre-com.20230601.gappssmtp.com (From: gstols@baylibre.com)
---
Total patches: 10
---
 Base: using specified base-commit 07d4d0bb4a8ddcc463ed599b22f510d5926c2495
Applying: dt-bindings: iio: adc: adi,ad7606: add missing datasheet link
Applying: dt-bindings: iio: adc: adi,ad7606: comment and sort the compatible names
Applying: dt-bindings: iio: adc: adi,ad7606: normalize textwidth
Applying: dt-bindings: iio: adc: adi,ad7606: improve descriptions
Applying: dt-bindings: iio: adc: adi,ad7606: add supply properties
Applying: dt-bindings: iio: adc: adi,ad7606: fix example
Applying: dt-bindings: iio: adc: adi,ad7606: add conditions
Applying: iio: adc: ad7606: fix oversampling gpio array
Applying: iio: adc: ad7606: fix standby gpio state to match the documentation
Applying: iio: adc: ad7606: switch mutexes to scoped_guard

tbh, I'm not actually sure why I didn't ack those patches on v1, they
were all pretty trivial...
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
index d55c58400df5..00fdaed11cbd 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7606.yaml
@@ -20,9 +20,9 @@  properties:
   compatible:
     enum:
       - adi,ad7605-4
-      - adi,ad7606-8
-      - adi,ad7606-6
       - adi,ad7606-4
+      - adi,ad7606-6
+      - adi,ad7606-8  # Referred to as AD7606 (without -8) in the datasheet
       - adi,ad7606b
       - adi,ad7616