| Message ID | 8dded7c01676b68e3042dbd0021e97c198a03b49.1718643571.git.pav@iki.fi |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ,v2] shared/bap: make BT_BAP_* direction defines valid bitmasks | expand |
diff --git a/src/shared/bap-defs.h b/src/shared/bap-defs.h index 2467e816f..27fefa34f 100644 --- a/src/shared/bap-defs.h +++ b/src/shared/bap-defs.h @@ -15,10 +15,10 @@ #define __packed __attribute__((packed)) #endif -#define BT_BAP_SINK 0x01 -#define BT_BAP_SOURCE 0x02 -#define BT_BAP_BCAST_SOURCE 0x03 -#define BT_BAP_BCAST_SINK 0x04 +#define BT_BAP_SINK BIT(0) +#define BT_BAP_SOURCE BIT(1) +#define BT_BAP_BCAST_SOURCE BIT(2) +#define BT_BAP_BCAST_SINK BIT(3) #define BT_BAP_STREAM_TYPE_UCAST 0x01 #define BT_BAP_STREAM_TYPE_BCAST 0x02
The directions appear to be intended as bitmasks, as bt_bap_stream_io_dir() will bitwise or linked stream directions. Fix the defines to be separate bits. Fixes confusion due to BT_BAP_BCAST_SOURCE == BT_BAP_SINK|BT_BAP_SOURCE, which causes e.g. unicast transports to be in PENDING state after QoS although this does not make sense for BAP unicast Client. --- Notes: v2: use BIT macro src/shared/bap-defs.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)