| Message ID | 20240611094810.27475-2-piotr.wojtaszczyk@timesys.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs | expand |
On Tue, Jun 11, 2024 at 12:45 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Changes for v2: > > - Added maintainers field > > - Dropped clock-names > > - Dropped unused unneded interrupts field > > Does the device has interrupts or not? This should justify decision, not > current usage by drivers. Yes the device has interrupts but feeding data FIFOs is handled by DMA (amba-pl08x.c). Should I declare interrupts despite they are not used in the compatible driver?
On 12/06/2024 10:06, Piotr Wojtaszczyk wrote: > On Tue, Jun 11, 2024 at 12:45 PM Krzysztof Kozlowski <krzk@kernel.org> wrote: >>> Changes for v2: >>> - Added maintainers field >>> - Dropped clock-names >>> - Dropped unused unneded interrupts field >> >> Does the device has interrupts or not? This should justify decision, not >> current usage by drivers. > Yes the device has interrupts but feeding data FIFOs is handled by DMA > (amba-pl08x.c). > Should I declare interrupts despite they are not used in the compatible driver? Yes. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml b/Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml new file mode 100644 index 000000000000..66e48d8a5a1b --- /dev/null +++ b/Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/nxp,lpc3220-i2s.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP LPC32XX I2S Controller + +description: + The I2S controller in LPC32XX SoCs to interface codecs and other audo devices. + +maintainers: + - Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com> + +properties: + compatible: + enum: + - nxp,lpc3220-i2s + + reg: + maxItems: 1 + + clocks: + items: + - description: input clock of the peripheral. + +required: + - compatible + - reg + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/lpc32xx-clock.h> + + i2s0: i2s@20094000 { + compatible = "nxp,lpc3220-i2s"; + reg = <0x20094000 0x1000>; + clocks = <&clk LPC32XX_CLK_I2S0>; + clock-names = "i2s_clk"; + status = "disabled"; + }; + +...
Add nxp,lpc3220-i2s DT binding documentation. Signed-off-by: Piotr Wojtaszczyk <piotr.wojtaszczyk@timesys.com> --- Changes for v2: - Added maintainers field - Dropped clock-names - Dropped unused unneded interrupts field .../bindings/sound/nxp,lpc3220-i2s.yaml | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/nxp,lpc3220-i2s.yaml