diff mbox series

[v5,4/4] arm64: dts: qcom: sc7280: Add clocks for QOS configuration

Message ID 20240607173927.26321-5-quic_okukatla@quicinc.com
State Accepted
Commit 2b5004956affaa6dd1d23d431876ad533f10418b
Headers show
Series Add support for QoS configuration | expand

Commit Message

Odelu Kukatla June 7, 2024, 5:39 p.m. UTC
Add clocks which need to be enbaled for configuring
QoS on sc7280.

Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
 1 file changed, 3 insertions(+)

Comments

Konrad Dybcio June 18, 2024, 2:47 p.m. UTC | #1
On 6/7/24 19:39, Odelu Kukatla wrote:
> Add clocks which need to be enbaled for configuring
> QoS on sc7280.
> 
> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Georgi Djakov June 25, 2024, 1:37 p.m. UTC | #2
On 7.06.24 20:39, Odelu Kukatla wrote:
> Add clocks which need to be enbaled for configuring
> QoS on sc7280.
> 

Nit: s/enbaled/enabled/

> Signed-off-by: Odelu Kukatla <quic_okukatla@quicinc.com>

In any case:
Acked-by: Georgi Djakov <djakov@kernel.org>

Bjorn, the dt-binding change is available in my icc-rpmh-qos branch
in case you want to make the dtbs checker happy when you apply this.

BR,
Georgi

> ---
>   arch/arm64/boot/dts/qcom/sc7280.dtsi | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index ba43fba2c551..a3c640d394e9 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2130,6 +2130,8 @@
>   			reg = <0 0x016e0000 0 0x1c080>;
>   			#interconnect-cells = <2>;
>   			qcom,bcm-voters = <&apps_bcm_voter>;
> +			clocks = <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>,
> +				 <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>;
>   		};
>   
>   		aggre2_noc: interconnect@1700000 {
> @@ -2137,6 +2139,7 @@
>   			compatible = "qcom,sc7280-aggre2-noc";
>   			#interconnect-cells = <2>;
>   			qcom,bcm-voters = <&apps_bcm_voter>;
> +			clocks = <&rpmhcc RPMH_IPA_CLK>;
>   		};
>   
>   		mmss_noc: interconnect@1740000 {
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index ba43fba2c551..a3c640d394e9 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2130,6 +2130,8 @@ 
 			reg = <0 0x016e0000 0 0x1c080>;
 			#interconnect-cells = <2>;
 			qcom,bcm-voters = <&apps_bcm_voter>;
+			clocks = <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>,
+				 <&gcc GCC_AGGRE_USB3_PRIM_AXI_CLK>;
 		};
 
 		aggre2_noc: interconnect@1700000 {
@@ -2137,6 +2139,7 @@ 
 			compatible = "qcom,sc7280-aggre2-noc";
 			#interconnect-cells = <2>;
 			qcom,bcm-voters = <&apps_bcm_voter>;
+			clocks = <&rpmhcc RPMH_IPA_CLK>;
 		};
 
 		mmss_noc: interconnect@1740000 {