| Message ID | 20240606-tps6598x_fw_update_log-v1-3-2b5b8369a0ba@wolfvision.net |
|---|---|
| State | New |
| Headers | show |
| Series | usb: typec: tipd: minor improvements in the firmware update code | expand |
On Thu, Jun 06, 2024 at 11:03:57AM +0200, Javier Carrasco wrote: > Simplify the current firmware packet size check in the tps6598x > implementation by means of a single call to min(), which is what the > current code does in a more verbose, less elegant way. > > This patch fixes a cocci warning ("WARNING opportunity for min()"). > > Suggested-by: Julia Lawall <julia.lawall@inria.fr> > Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> > --- > drivers/usb/typec/tipd/core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c > index 58f6eeffd070..ea768b19a7f1 100644 > --- a/drivers/usb/typec/tipd/core.c > +++ b/drivers/usb/typec/tipd/core.c > @@ -1165,10 +1165,7 @@ static int tps6598x_apply_patch(struct tps6598x *tps) > > bytes_left = fw->size; > while (bytes_left) { > - if (bytes_left < TPS_MAX_LEN) > - in_len = bytes_left; > - else > - in_len = TPS_MAX_LEN; > + in_len = min(bytes_left, TPS_MAX_LEN); > ret = tps6598x_exec_cmd(tps, "PTCd", in_len, > fw->data + copied_bytes, > TPS_PTCD_OUT_BYTES, out); > > -- > 2.40.1
diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 58f6eeffd070..ea768b19a7f1 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -1165,10 +1165,7 @@ static int tps6598x_apply_patch(struct tps6598x *tps) bytes_left = fw->size; while (bytes_left) { - if (bytes_left < TPS_MAX_LEN) - in_len = bytes_left; - else - in_len = TPS_MAX_LEN; + in_len = min(bytes_left, TPS_MAX_LEN); ret = tps6598x_exec_cmd(tps, "PTCd", in_len, fw->data + copied_bytes, TPS_PTCD_OUT_BYTES, out);
Simplify the current firmware packet size check in the tps6598x implementation by means of a single call to min(), which is what the current code does in a more verbose, less elegant way. This patch fixes a cocci warning ("WARNING opportunity for min()"). Suggested-by: Julia Lawall <julia.lawall@inria.fr> Signed-off-by: Javier Carrasco <javier.carrasco@wolfvision.net> --- drivers/usb/typec/tipd/core.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)