| Message ID | 20240605160032.150587-3-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | 46822d2750822dbe58bcd999cbedf24147cb5fc3 |
| Headers | show |
| Series | [RFT,1/4] arm64: dts: qcom: sm6350-pdx213: correct touchscreen interrupt flags | expand |
On 5.06.2024 6:00 PM, Krzysztof Kozlowski wrote: > Interrupt flags 0x2008 looks like some downstream copy-paste, because > generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores > flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to > pass just 0x8, so IRQ_TYPE_LEVEL_LOW. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad
diff --git a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi index e07d0311ecb5..f6870d3f2886 100644 --- a/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi @@ -520,7 +520,7 @@ touchscreen@48 { compatible = "samsung,s6sy761"; reg = <0x48>; interrupt-parent = <&tlmm>; - interrupts = <39 0x2008>; + interrupts = <39 IRQ_TYPE_LEVEL_LOW>; /* It's "vddio" downstream but it works anyway! */ vdd-supply = <&vreg_l1c_1p8>; avdd-supply = <&vreg_l10c_3p3>;
Interrupt flags 0x2008 looks like some downstream copy-paste, because generic GPIOLIB code, used by Qualcomm pin controller drivers, ignores flags outside of IRQ_TYPE_SENSE_MASK. Probably the intention was to pass just 0x8, so IRQ_TYPE_LEVEL_LOW. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm64/boot/dts/qcom/sm8250-sony-xperia-edo.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)