| Message ID | 20240605-topic-amlogic-upstream-bindings-fixes-audio-widgets-v1-1-65bd7cc2e09b@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: dt-bindings: amlogic,gx-sound-card: drop minItems for audio-widgets | expand |
On Wed, 05 Jun 2024 11:40:51 +0200, Neil Armstrong wrote: > Like "audio-routing" drop the minItems: 2 from the "audio-widgets", because > any limit here - lower or upper- is rather meaningless. > > This will also fix `dtbs_check` warnings like: > sound: audio-widgets: ['Speaker', '7J4-14 LEFT', 'Speaker', '7J4-11 RIGHT'] is too long > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml | 1 - > 1 file changed, 1 deletion(-) > Acked-by: Rob Herring (Arm) <robh@kernel.org>
Hi Mark, On 05/06/2024 11:40, Neil Armstrong wrote: > Like "audio-routing" drop the minItems: 2 from the "audio-widgets", because > any limit here - lower or upper- is rather meaningless. > > This will also fix `dtbs_check` warnings like: > sound: audio-widgets: ['Speaker', '7J4-14 LEFT', 'Speaker', '7J4-11 RIGHT'] is too long > > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > --- > Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml > index d4277d342e69..0ecdaf7190e9 100644 > --- a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml > +++ b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml > @@ -23,7 +23,6 @@ properties: > > audio-widgets: > $ref: /schemas/types.yaml#/definitions/non-unique-string-array > - minItems: 2 > description: |- > A list off component DAPM widget. Each entry is a pair of strings, > the first being the widget type, the second being the widget name > > --- > base-commit: c3f38fa61af77b49866b006939479069cd451173 > change-id: 20240605-topic-amlogic-upstream-bindings-fixes-audio-widgets-00e1afcda10b > > Best regards, Gentle ping ! Thanks, Neil
On Mon, Jun 24, 2024 at 11:13:44AM +0200, Neil Armstrong wrote:
> Gentle ping !
Please don't send content free pings and please allow a reasonable time
for review. People get busy, go on holiday, attend conferences and so
on so unless there is some reason for urgency (like critical bug fixes)
please allow at least a couple of weeks for review. If there have been
review comments then people may be waiting for those to be addressed.
Sending content free pings adds to the mail volume (if they are seen at
all) which is often the problem and since they can't be reviewed
directly if something has gone wrong you'll have to resend the patches
anyway, so sending again is generally a better approach though there are
some other maintainers who like them - if in doubt look at how patches
for the subsystem are normally handled.
diff --git a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml index d4277d342e69..0ecdaf7190e9 100644 --- a/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml +++ b/Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml @@ -23,7 +23,6 @@ properties: audio-widgets: $ref: /schemas/types.yaml#/definitions/non-unique-string-array - minItems: 2 description: |- A list off component DAPM widget. Each entry is a pair of strings, the first being the widget type, the second being the widget name
Like "audio-routing" drop the minItems: 2 from the "audio-widgets", because any limit here - lower or upper- is rather meaningless. This will also fix `dtbs_check` warnings like: sound: audio-widgets: ['Speaker', '7J4-14 LEFT', 'Speaker', '7J4-11 RIGHT'] is too long Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- Documentation/devicetree/bindings/sound/amlogic,gx-sound-card.yaml | 1 - 1 file changed, 1 deletion(-) --- base-commit: c3f38fa61af77b49866b006939479069cd451173 change-id: 20240605-topic-amlogic-upstream-bindings-fixes-audio-widgets-00e1afcda10b Best regards,