| Message ID | 20120423070925.GG30752@lizard |
|---|---|
| State | Accepted |
| Commit | 9bd0a077122a6b15069aab7a59c8f50f736fa1dd |
| Headers | show |
On 23.04.2012 09:09, Anton Vorontsov wrote: > Traversing the tasks requires holding tasklist_lock, otherwise it > is unsafe. > > p.s. However, I'm not sure that calling os_kill_ptraced_process() > in the atomic context is correct. It seem to work, but please > take a closer look. > > Signed-off-by: Anton Vorontsov<anton.vorontsov@linaro.org> > --- You forgot my Ack and I've already explained why os_kill_ptraced_process() is fine. Thanks, //richard
On Mon, Apr 23, 2012 at 04:57:54PM +0200, Richard Weinberger wrote: > On 23.04.2012 09:09, Anton Vorontsov wrote: > >Traversing the tasks requires holding tasklist_lock, otherwise it > >is unsafe. > > > >p.s. However, I'm not sure that calling os_kill_ptraced_process() > >in the atomic context is correct. It seem to work, but please > >take a closer look. > > > >Signed-off-by: Anton Vorontsov<anton.vorontsov@linaro.org> > >--- > > You forgot my Ack and I've already explained why > os_kill_ptraced_process() is fine. Ouch, sorry!
diff --git a/arch/um/kernel/reboot.c b/arch/um/kernel/reboot.c index 4d93dff..66d754c 100644 --- a/arch/um/kernel/reboot.c +++ b/arch/um/kernel/reboot.c @@ -4,6 +4,7 @@ */ #include "linux/sched.h" +#include "linux/spinlock.h" #include "linux/slab.h" #include "kern_util.h" #include "os.h" @@ -22,6 +23,7 @@ static void kill_off_processes(void) struct task_struct *p; int pid; + read_lock(&tasklist_lock); for_each_process(p) { if (p->mm == NULL) continue; @@ -29,6 +31,7 @@ static void kill_off_processes(void) pid = p->mm->context.id.u.pid; os_kill_ptraced_process(pid, 1); } + read_unlock(&tasklist_lock); } }
Traversing the tasks requires holding tasklist_lock, otherwise it is unsafe. p.s. However, I'm not sure that calling os_kill_ptraced_process() in the atomic context is correct. It seem to work, but please take a closer look. Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org> --- arch/um/kernel/reboot.c | 3 +++ 1 file changed, 3 insertions(+)