diff mbox series

[v2,1/3] target/mips: Restrict semihosting to TCG

Message ID 20240530145349.41309-2-philmd@linaro.org
State Superseded
Headers show
Series semihosting: Restrict to TCG | expand

Commit Message

Philippe Mathieu-Daudé May 30, 2024, 2:53 p.m. UTC
Semihosting currently uses the TCG probe_access API. To prepare for
encoding the TCG dependency in Kconfig, do not enable it unless TCG
is available.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/mips/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Anton Johansson June 7, 2024, 11:08 a.m. UTC | #1
On 30/05/24, Philippe Mathieu-Daudé wrote:
> Semihosting currently uses the TCG probe_access API. To prepare for
> encoding the TCG dependency in Kconfig, do not enable it unless TCG
> is available.
> 
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/mips/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

xtensa and m68k also `select SEMIHOSTING`, were these missed?

Otherwise for patch 1 & 2:
Reviewed-by: Anton Johansson <anjo@rev.ng>
Philippe Mathieu-Daudé June 7, 2024, 1:48 p.m. UTC | #2
On 7/6/24 13:08, Anton Johansson wrote:
> On 30/05/24, Philippe Mathieu-Daudé wrote:
>> Semihosting currently uses the TCG probe_access API. To prepare for
>> encoding the TCG dependency in Kconfig, do not enable it unless TCG
>> is available.
>>
>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>>   target/mips/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> xtensa and m68k also `select SEMIHOSTING`, were these missed?

TCG is the only accelerator they use, so it is kinda implicit,
but you are right, I'll update for completeness.

> Otherwise for patch 1 & 2:
> Reviewed-by: Anton Johansson <anjo@rev.ng>

Thanks!
Alex Bennée June 10, 2024, 9:29 a.m. UTC | #3
Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> On 7/6/24 13:08, Anton Johansson wrote:
>> On 30/05/24, Philippe Mathieu-Daudé wrote:
>>> Semihosting currently uses the TCG probe_access API. To prepare for
>>> encoding the TCG dependency in Kconfig, do not enable it unless TCG
>>> is available.
>>>
>>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> ---
>>>   target/mips/Kconfig | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> xtensa and m68k also `select SEMIHOSTING`, were these missed?
>
> TCG is the only accelerator they use, so it is kinda implicit,
> but you are right, I'll update for completeness.

So I'll wait for a v3?

>
>> Otherwise for patch 1 & 2:
>> Reviewed-by: Anton Johansson <anjo@rev.ng>
>
> Thanks!
Philippe Mathieu-Daudé June 10, 2024, 2:55 p.m. UTC | #4
On 10/6/24 11:29, Alex Bennée wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> 
>> On 7/6/24 13:08, Anton Johansson wrote:
>>> On 30/05/24, Philippe Mathieu-Daudé wrote:
>>>> Semihosting currently uses the TCG probe_access API. To prepare for
>>>> encoding the TCG dependency in Kconfig, do not enable it unless TCG
>>>> is available.
>>>>
>>>> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>>> ---
>>>>    target/mips/Kconfig | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>> xtensa and m68k also `select SEMIHOSTING`, were these missed?
>>
>> TCG is the only accelerator they use, so it is kinda implicit,
>> but you are right, I'll update for completeness.
> 
> So I'll wait for a v3?

Yes, on the way...
diff mbox series

Patch

diff --git a/target/mips/Kconfig b/target/mips/Kconfig
index eb19c94c7d..876048b150 100644
--- a/target/mips/Kconfig
+++ b/target/mips/Kconfig
@@ -1,6 +1,6 @@ 
 config MIPS
     bool
-    select SEMIHOSTING
+    imply SEMIHOSTING if TCG
 
 config MIPS64
     bool