| Message ID | 20240527191940.30107-1-pierre-louis.bossart@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | b062938fd9afec844c50571fddd8d81623a60ee1 |
| Headers | show |
| Series | ASoC: Intel: sof-sdw: fix missing SPI_MASTER dependency | expand |
On Mon, May 27, 2024 at 02:19:40PM -0500, Pierre-Louis Bossart wrote: > The addition of the Cirrus Logic 'sidecar' amps adds a dependency on SPI_MASTER. > > Kconfig warnings: (for reference only) > WARNING: unmet direct dependencies detected for SND_SOC_CS35L56_SPI > Depends on [n]: > SOUND [=y] && SND [=y] && SND_SOC [=y] && SPI_MASTER [=n] && > (SOUNDWIRE [=y] || !SOUNDWIRE [=y]) > Selected by [y]: > - SND_SOC_INTEL_SOUNDWIRE_SOF_MACH [=y] && SOUND [=y] && SND [=y] > && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && > SND_SOC_SOF_INTEL_SOUNDWIRE [=y] && I2C [=y] && ACPI [=y] && > (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n]) && > (SND_SOC_INTEL_USER_FRIENDLY_LONG_NAMES [=y] || COMPILE_TEST > [=n]) && SOUNDWIRE [=y] > > Fixes: b831b4dca48d ("ASoC: intel: sof_sdw: Add support for cs42l43-cs35l56 sidecar amps") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202405140758.o2HY4nYD-lkp@intel.com/ > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> > --- Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com> Thanks, Charles
On Mon, 27 May 2024 14:19:40 -0500, Pierre-Louis Bossart wrote: > The addition of the Cirrus Logic 'sidecar' amps adds a dependency on SPI_MASTER. > > Kconfig warnings: (for reference only) > WARNING: unmet direct dependencies detected for SND_SOC_CS35L56_SPI > Depends on [n]: > SOUND [=y] && SND [=y] && SND_SOC [=y] && SPI_MASTER [=n] && > (SOUNDWIRE [=y] || !SOUNDWIRE [=y]) > Selected by [y]: > - SND_SOC_INTEL_SOUNDWIRE_SOF_MACH [=y] && SOUND [=y] && SND [=y] > && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && > SND_SOC_SOF_INTEL_SOUNDWIRE [=y] && I2C [=y] && ACPI [=y] && > (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n]) && > (SND_SOC_INTEL_USER_FRIENDLY_LONG_NAMES [=y] || COMPILE_TEST > [=n]) && SOUNDWIRE [=y] > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: Intel: sof-sdw: fix missing SPI_MASTER dependency commit: b062938fd9afec844c50571fddd8d81623a60ee1 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/intel/boards/Kconfig b/sound/soc/intel/boards/Kconfig index 3ed81ab649c5..4e0586034de4 100644 --- a/sound/soc/intel/boards/Kconfig +++ b/sound/soc/intel/boards/Kconfig @@ -652,7 +652,7 @@ if SND_SOC_SOF_INTEL_SOUNDWIRE config SND_SOC_INTEL_SOUNDWIRE_SOF_MACH tristate "SoundWire generic machine driver" - depends on I2C && ACPI + depends on I2C && SPI_MASTER && ACPI depends on MFD_INTEL_LPSS || COMPILE_TEST depends on SND_SOC_INTEL_USER_FRIENDLY_LONG_NAMES || COMPILE_TEST depends on SOUNDWIRE
The addition of the Cirrus Logic 'sidecar' amps adds a dependency on SPI_MASTER. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for SND_SOC_CS35L56_SPI Depends on [n]: SOUND [=y] && SND [=y] && SND_SOC [=y] && SPI_MASTER [=n] && (SOUNDWIRE [=y] || !SOUNDWIRE [=y]) Selected by [y]: - SND_SOC_INTEL_SOUNDWIRE_SOF_MACH [=y] && SOUND [=y] && SND [=y] && SND_SOC [=y] && SND_SOC_INTEL_MACH [=y] && SND_SOC_SOF_INTEL_SOUNDWIRE [=y] && I2C [=y] && ACPI [=y] && (MFD_INTEL_LPSS [=y] || COMPILE_TEST [=n]) && (SND_SOC_INTEL_USER_FRIENDLY_LONG_NAMES [=y] || COMPILE_TEST [=n]) && SOUNDWIRE [=y] Fixes: b831b4dca48d ("ASoC: intel: sof_sdw: Add support for cs42l43-cs35l56 sidecar amps") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202405140758.o2HY4nYD-lkp@intel.com/ Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com> --- sound/soc/intel/boards/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)