diff mbox series

crypto: hifn_795x: Remove unused hifn_*_command structs

Message ID 20240511145426.226379-1-linux@treblig.org
State Accepted
Commit eaa857782fdbba36544c74006d8037f4d101b90a
Headers show
Series crypto: hifn_795x: Remove unused hifn_*_command structs | expand

Commit Message

Dr. David Alan Gilbert May 11, 2024, 2:54 p.m. UTC
From: "Dr. David Alan Gilbert" <linux@treblig.org>

Remove 'hifn_mac_command' and 'hifn_comp_command' which are unused.
They're the same structure as 'hifn_crypt_command' which is used.

(I was tempted to remove
   hifn_base_result
   hifn_comp_result
   hifn_mac_result and
   hifn_crypt_result
which are also unused, but they vary, and perhaps they're telling
someone in the future what to look at.)

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 drivers/crypto/hifn_795x.c | 17 -----------------
 1 file changed, 17 deletions(-)

Comments

Herbert Xu May 31, 2024, 9:58 a.m. UTC | #1
On Sat, May 11, 2024 at 03:54:26PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> Remove 'hifn_mac_command' and 'hifn_comp_command' which are unused.
> They're the same structure as 'hifn_crypt_command' which is used.
> 
> (I was tempted to remove
>    hifn_base_result
>    hifn_comp_result
>    hifn_mac_result and
>    hifn_crypt_result
> which are also unused, but they vary, and perhaps they're telling
> someone in the future what to look at.)
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  drivers/crypto/hifn_795x.c | 17 -----------------
>  1 file changed, 17 deletions(-)

Patch applied.  Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c
index b4a4ec35bce05..9259915267454 100644
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -495,16 +495,6 @@  struct hifn_crypt_command {
 #define	HIFN_CRYPT_CMD_SRCLEN_M		0xc000
 #define	HIFN_CRYPT_CMD_SRCLEN_S		14
 
-/*
- * Structure to help build up the command data structure.
- */
-struct hifn_mac_command {
-	volatile __le16	masks;
-	volatile __le16	header_skip;
-	volatile __le16	source_count;
-	volatile __le16	reserved;
-};
-
 #define	HIFN_MAC_CMD_ALG_MASK		0x0001
 #define	HIFN_MAC_CMD_ALG_SHA1		0x0000
 #define	HIFN_MAC_CMD_ALG_MD5		0x0001
@@ -526,13 +516,6 @@  struct hifn_mac_command {
 #define	HIFN_MAC_CMD_POS_IPSEC		0x0200
 #define	HIFN_MAC_CMD_NEW_KEY		0x0800
 
-struct hifn_comp_command {
-	volatile __le16		masks;
-	volatile __le16		header_skip;
-	volatile __le16		source_count;
-	volatile __le16		reserved;
-};
-
 #define	HIFN_COMP_CMD_SRCLEN_M		0xc000
 #define	HIFN_COMP_CMD_SRCLEN_S		14
 #define	HIFN_COMP_CMD_ONE		0x0100	/* must be one */