Message ID | ce0337178bf617d52ff320a36837d75bf537df2d.1715813148.git.sean.wang@kernel.org |
---|---|
State | New |
Headers | show |
Series | [v5,1/5] Bluetooth: btmtk: add the function to get the fw name | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=853525 ---Test result--- Test Summary: CheckPatch PASS 3.60 seconds GitLint FAIL 1.71 seconds SubjectPrefix PASS 0.58 seconds BuildKernel PASS 29.25 seconds CheckAllWarning PASS 32.14 seconds CheckSparse PASS 37.90 seconds CheckSmatch FAIL 34.30 seconds BuildKernel32 PASS 28.20 seconds TestRunnerSetup PASS 513.42 seconds TestRunner_l2cap-tester PASS 18.10 seconds TestRunner_iso-tester PASS 28.65 seconds TestRunner_bnep-tester PASS 4.71 seconds TestRunner_mgmt-tester PASS 112.77 seconds TestRunner_rfcomm-tester PASS 7.28 seconds TestRunner_sco-tester PASS 14.84 seconds TestRunner_ioctl-tester PASS 7.62 seconds TestRunner_mesh-tester PASS 5.79 seconds TestRunner_smp-tester PASS 6.73 seconds TestRunner_userchan-tester PASS 4.87 seconds IncrementalBuild PASS 48.16 seconds Details ############################## Test: GitLint - FAIL Desc: Run gitlint Output: [v5,4/5] Bluetooth: btusb: mediatek: reset the controller before downloading the fw WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 1: T1 Title exceeds max length (83>80): "[v5,4/5] Bluetooth: btusb: mediatek: reset the controller before downloading the fw" ############################## Test: CheckSmatch - FAIL Desc: Run smatch tool with source Output: Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139 make[4]: *** Deleting file 'net/bluetooth/hci_core.o' make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: net] Error 2 make[2]: *** Waiting for unfinished jobs.... Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139 make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o' make[4]: *** Waiting for unfinished jobs.... make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: drivers] Error 2 make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2 make: *** [Makefile:240: __sub-make] Error 2 --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Wed, 15 May 2024 16:15:17 -0700 you wrote: > From: Sean Wang <sean.wang@mediatek.com> > > Include a shared function to get the firmware name, to prevent repeating > code for similar chipsets. > > Signed-off-by: Sean Wang <sean.wang@mediatek.com> > > [...] Here is the summary with links: - [v5,1/5] Bluetooth: btmtk: add the function to get the fw name https://git.kernel.org/bluetooth/bluetooth-next/c/1a9f00aa23b8 - [v5,2/5] Bluetooth: btmtk: apply the common btmtk_fw_get_filename https://git.kernel.org/bluetooth/bluetooth-next/c/8a5b9ee69fe6 - [v5,3/5] Bluetooth: btusb: mediatek: refactor the function btusb_mtk_reset https://git.kernel.org/bluetooth/bluetooth-next/c/9d5a3b40987d - [v5,4/5] Bluetooth: btusb: mediatek: reset the controller before downloading the fw https://git.kernel.org/bluetooth/bluetooth-next/c/8f9fa6c70d35 - [v5,5/5] Bluetooth: btusb: mediatek: add MT7922 subsystem reset https://git.kernel.org/bluetooth/bluetooth-next/c/2a6bc5724952 You are awesome, thank you!
diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c index 812fd2a8f853..a27c251bf56e 100644 --- a/drivers/bluetooth/btmtk.c +++ b/drivers/bluetooth/btmtk.c @@ -103,6 +103,24 @@ static void btmtk_coredump_notify(struct hci_dev *hdev, int state) } } +void btmtk_fw_get_filename(char *buf, size_t size, u32 dev_id, u32 fw_ver, + u32 fw_flavor) +{ + if (dev_id == 0x7925) + snprintf(buf, size, + "mediatek/mt%04x/BT_RAM_CODE_MT%04x_1_%x_hdr.bin", + dev_id & 0xffff, dev_id & 0xffff, (fw_ver & 0xff) + 1); + else if (dev_id == 0x7961 && fw_flavor) + snprintf(buf, size, + "mediatek/BT_RAM_CODE_MT%04x_1a_%x_hdr.bin", + dev_id & 0xffff, (fw_ver & 0xff) + 1); + else + snprintf(buf, size, + "mediatek/BT_RAM_CODE_MT%04x_1_%x_hdr.bin", + dev_id & 0xffff, (fw_ver & 0xff) + 1); +} +EXPORT_SYMBOL_GPL(btmtk_fw_get_filename); + int btmtk_setup_firmware_79xx(struct hci_dev *hdev, const char *fwname, wmt_cmd_sync_func_t wmt_cmd_sync) { diff --git a/drivers/bluetooth/btmtk.h b/drivers/bluetooth/btmtk.h index cbcdb99a22e6..e76b8a358be8 100644 --- a/drivers/bluetooth/btmtk.h +++ b/drivers/bluetooth/btmtk.h @@ -160,6 +160,9 @@ int btmtk_register_coredump(struct hci_dev *hdev, const char *name, u32 fw_version); int btmtk_process_coredump(struct hci_dev *hdev, struct sk_buff *skb); + +void btmtk_fw_get_filename(char *buf, size_t size, u32 dev_id, u32 fw_ver, + u32 fw_flavor); #else static inline int btmtk_set_bdaddr(struct hci_dev *hdev, @@ -194,4 +197,9 @@ static int btmtk_process_coredump(struct hci_dev *hdev, struct sk_buff *skb) { return -EOPNOTSUPP; } + +static void btmtk_fw_get_filename(char *buf, size_t size, u32 dev_id, + u32 fw_ver, u32 fw_flavor) +{ +} #endif