| Message ID | 20240511013644.3103905-3-quic_periyasa@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | wifi: ath12k: Refactor MAX_RADIOS definition | expand |
On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote: > The current value of the MAX_RADIOS define is 3. However, this value is > incorrect as the maximum number of radios supported by all devices does > not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2. Use imperative tense: Therefore, modify ... What is the observed problem, if any, with the current code? > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> > --- > drivers/net/wireless/ath/ath12k/wmi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h > index 496866673aea..27bec3800bff 100644 > --- a/drivers/net/wireless/ath/ath12k/wmi.h > +++ b/drivers/net/wireless/ath/ath12k/wmi.h > @@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd { > __le32 buf_len; > } __packed; > > -#define MAX_RADIOS 3 > +#define MAX_RADIOS 2 > > #define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ) > #define WMI_SEND_TIMEOUT_HZ (3 * HZ)
On 5/14/2024 5:01 AM, Jeff Johnson wrote: > On 5/10/2024 6:36 PM, Karthikeyan Periyasamy wrote: >> The current value of the MAX_RADIOS define is 3. However, this value is >> incorrect as the maximum number of radios supported by all devices does >> not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2. > > Use imperative tense: Therefore, modify ... > Sure, will modify in the next version. > What is the observed problem, if any, with the current code? > No problem observed but it leads to unnecessary space allocated for the hw links in the group and also it gives incorrect perspective to the code reader that ath12k support max three radio platform. >> >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> >> --- >> drivers/net/wireless/ath/ath12k/wmi.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h >> index 496866673aea..27bec3800bff 100644 >> --- a/drivers/net/wireless/ath/ath12k/wmi.h >> +++ b/drivers/net/wireless/ath/ath12k/wmi.h >> @@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd { >> __le32 buf_len; >> } __packed; >> >> -#define MAX_RADIOS 3 >> +#define MAX_RADIOS 2 >> >> #define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ) >> #define WMI_SEND_TIMEOUT_HZ (3 * HZ) >
diff --git a/drivers/net/wireless/ath/ath12k/wmi.h b/drivers/net/wireless/ath/ath12k/wmi.h index 496866673aea..27bec3800bff 100644 --- a/drivers/net/wireless/ath/ath12k/wmi.h +++ b/drivers/net/wireless/ath/ath12k/wmi.h @@ -4770,7 +4770,7 @@ struct wmi_probe_tmpl_cmd { __le32 buf_len; } __packed; -#define MAX_RADIOS 3 +#define MAX_RADIOS 2 #define WMI_SERVICE_READY_TIMEOUT_HZ (5 * HZ) #define WMI_SEND_TIMEOUT_HZ (3 * HZ)
The current value of the MAX_RADIOS define is 3. However, this value is incorrect as the maximum number of radios supported by all devices does not exceed 2. Therefore, the MAX_RADIOS define should be modified to 2. Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Signed-off-by: Karthikeyan Periyasamy <quic_periyasa@quicinc.com> --- drivers/net/wireless/ath/ath12k/wmi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)