| Message ID | 20161026190504.9888-12-lersek@redhat.com |
|---|---|
| State | Accepted |
| Commit | bd4b5962d940017bb3054c7a517576daeda4eed7 |
| Headers | show |
Ray, On 10/26/16 21:04, Laszlo Ersek wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > --- > DuetPkg/Library/DuetBdsLib/BdsPlatform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c > index 1875dc963680..a4b2aa947322 100644 > --- a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c > +++ b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c > @@ -64,7 +64,7 @@ Returns: > // > // Iteratively add ACPI Table, SMBIOS Table, MPS Table to EFI System Table > // > - for (Index = 0; Index < sizeof (gTableGuidArray) / sizeof (*gTableGuidArray); ++Index) { > + for (Index = 0; Index < ARRAY_SIZE (gTableGuidArray); ++Index) { > GuidHob.Raw = GetNextGuidHob (gTableGuidArray[Index], HobStart.Raw); > if (GuidHob.Raw != NULL) { > Table = GET_GUID_HOB_DATA (GuidHob.Guid); > I'm very sorry, I forgot to CC you on this patch originally. Can you please review it? Thank you! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com> Regards, Ray From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, October 27, 2016 4:17 PM To: edk2-devel-01 <edk2-devel@ml01.01.org>; Ni, Ruiyu <ruiyu.ni@intel.com> Subject: Re: [edk2] [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE() Ray, On 10/26/16 21:04, Laszlo Ersek wrote: > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>> > --- > DuetPkg/Library/DuetBdsLib/BdsPlatform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c > index 1875dc963680..a4b2aa947322 100644 > --- a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c > +++ b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c > @@ -64,7 +64,7 @@ Returns: > // > // Iteratively add ACPI Table, SMBIOS Table, MPS Table to EFI System Table > // > - for (Index = 0; Index < sizeof (gTableGuidArray) / sizeof (*gTableGuidArray); ++Index) { > + for (Index = 0; Index < ARRAY_SIZE (gTableGuidArray); ++Index) { > GuidHob.Raw = GetNextGuidHob (gTableGuidArray[Index], HobStart.Raw); > if (GuidHob.Raw != NULL) { > Table = GET_GUID_HOB_DATA (GuidHob.Guid); > I'm very sorry, I forgot to CC you on this patch originally. Can you please review it? Thank you! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 10/27/16 11:04, Ni, Ruiyu wrote: > Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com> Thanks! Laszlo > Regards, > Ray > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek > Sent: Thursday, October 27, 2016 4:17 PM > To: edk2-devel-01 <edk2-devel@ml01.01.org>; Ni, Ruiyu <ruiyu.ni@intel.com> > Subject: Re: [edk2] [PATCH 11/47] DuetPkg/DuetBdsLib: rebase to ARRAY_SIZE() > > Ray, > > On 10/26/16 21:04, Laszlo Ersek wrote: >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek <lersek@redhat.com<mailto:lersek@redhat.com>> >> --- >> DuetPkg/Library/DuetBdsLib/BdsPlatform.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c >> index 1875dc963680..a4b2aa947322 100644 >> --- a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c >> +++ b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c >> @@ -64,7 +64,7 @@ Returns: >> // >> // Iteratively add ACPI Table, SMBIOS Table, MPS Table to EFI System Table >> // >> - for (Index = 0; Index < sizeof (gTableGuidArray) / sizeof (*gTableGuidArray); ++Index) { >> + for (Index = 0; Index < ARRAY_SIZE (gTableGuidArray); ++Index) { >> GuidHob.Raw = GetNextGuidHob (gTableGuidArray[Index], HobStart.Raw); >> if (GuidHob.Raw != NULL) { >> Table = GET_GUID_HOB_DATA (GuidHob.Guid); >> > > I'm very sorry, I forgot to CC you on this patch originally. Can you > please review it? > > Thank you! > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c index 1875dc963680..a4b2aa947322 100644 --- a/DuetPkg/Library/DuetBdsLib/BdsPlatform.c +++ b/DuetPkg/Library/DuetBdsLib/BdsPlatform.c @@ -64,7 +64,7 @@ Returns: // // Iteratively add ACPI Table, SMBIOS Table, MPS Table to EFI System Table // - for (Index = 0; Index < sizeof (gTableGuidArray) / sizeof (*gTableGuidArray); ++Index) { + for (Index = 0; Index < ARRAY_SIZE (gTableGuidArray); ++Index) { GuidHob.Raw = GetNextGuidHob (gTableGuidArray[Index], HobStart.Raw); if (GuidHob.Raw != NULL) { Table = GET_GUID_HOB_DATA (GuidHob.Guid);
Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> --- DuetPkg/Library/DuetBdsLib/BdsPlatform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel