| Message ID | 20240504020745.68525-2-felix@kaechele.ca |
|---|---|
| State | New |
| Headers | show |
| Series | [1/6] dt-bindings: input: touchscreen: himax,hx83112b: add HX83100A | expand |
On Sat, May 04, 2024 at 02:34:08PM +0200, Krzysztof Kozlowski wrote: > On 04/05/2024 04:04, Felix Kaechele wrote: > > This adds a compatible string for the Himax HX83100A touch controller > > Please do not use "This commit/patch/change", but imperative mood. See > longer explanation here: > https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 > > > including the AVDD and VDD supply nodes used by this chip family. > > > > Signed-off-by: Felix Kaechele <felix@kaechele.ca> > > --- > > .../bindings/input/touchscreen/himax,hx83112b.yaml | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml > > index f42b23d532eb..5809afedb9a2 100644 > > --- a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml > > +++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml > > @@ -15,6 +15,7 @@ allOf: > > properties: > > compatible: > > enum: > > + - himax,hx83100a > > - himax,hx83112b > > > > reg: > > @@ -26,6 +27,12 @@ properties: > > reset-gpios: > > maxItems: 1 > > > > + avdd-supply: > > + description: Analog power supply regulator > > + > > + vdd-supply: > > + description: Digital power supply regulator > > These should not be allowed for other variant, so either you need > allOf:if:then disallowing them (: false) or just create another binding > file. Or the commit message needs some explanation that the supplies also apply to the 83112b as the existing binding has no supplies. Rob
diff --git a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml index f42b23d532eb..5809afedb9a2 100644 --- a/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml +++ b/Documentation/devicetree/bindings/input/touchscreen/himax,hx83112b.yaml @@ -15,6 +15,7 @@ allOf: properties: compatible: enum: + - himax,hx83100a - himax,hx83112b reg: @@ -26,6 +27,12 @@ properties: reset-gpios: maxItems: 1 + avdd-supply: + description: Analog power supply regulator + + vdd-supply: + description: Digital power supply regulator + touchscreen-inverted-x: true touchscreen-inverted-y: true touchscreen-size-x: true @@ -54,6 +61,8 @@ examples: reg = <0x48>; interrupt-parent = <&tlmm>; interrupts = <65 IRQ_TYPE_LEVEL_LOW>; + avdd-supply = <&avdd_reg>; + vdd-supply = <&vdd_reg>; touchscreen-size-x = <1080>; touchscreen-size-y = <2160>; reset-gpios = <&tlmm 64 GPIO_ACTIVE_LOW>;
This adds a compatible string for the Himax HX83100A touch controller including the AVDD and VDD supply nodes used by this chip family. Signed-off-by: Felix Kaechele <felix@kaechele.ca> --- .../bindings/input/touchscreen/himax,hx83112b.yaml | 9 +++++++++ 1 file changed, 9 insertions(+)