| Message ID | 20240502171709.1280128-1-iam@sung-woo.kim |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v3] Bluetooth: HCI: Fix potential null-ptr-deref | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=849978 ---Test result--- Test Summary: CheckPatch PASS 0.58 seconds GitLint PASS 0.26 seconds SubjectPrefix PASS 0.09 seconds BuildKernel PASS 30.08 seconds CheckAllWarning PASS 32.96 seconds CheckSparse WARNING 38.13 seconds CheckSmatch FAIL 34.78 seconds BuildKernel32 PASS 29.46 seconds TestRunnerSetup PASS 520.97 seconds TestRunner_l2cap-tester PASS 18.30 seconds TestRunner_iso-tester PASS 30.93 seconds TestRunner_bnep-tester PASS 4.67 seconds TestRunner_mgmt-tester PASS 112.87 seconds TestRunner_rfcomm-tester PASS 7.21 seconds TestRunner_sco-tester PASS 15.19 seconds TestRunner_ioctl-tester PASS 7.63 seconds TestRunner_mesh-tester PASS 5.83 seconds TestRunner_smp-tester PASS 6.80 seconds TestRunner_userchan-tester PASS 4.86 seconds IncrementalBuild PASS 32.57 seconds Details ############################## Test: CheckSparse - WARNING Desc: Run sparse tool with linux kernel Output: net/bluetooth/hci_event.c: note: in included file (through include/net/bluetooth/hci_core.h): ############################## Test: CheckSmatch - FAIL Desc: Run smatch tool with source Output: Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139 make[4]: *** Deleting file 'net/bluetooth/hci_core.o' make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: net] Error 2 make[2]: *** Waiting for unfinished jobs.... Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139 make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o' make[4]: *** Waiting for unfinished jobs.... make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: drivers] Error 2 make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2 make: *** [Makefile:240: __sub-make] Error 2 --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 2 May 2024 13:17:10 -0400 you wrote: > Fix potential null-ptr-deref in hci_le_big_sync_established_evt(). > > Fixes: f777d8827817 ("Bluetooth: ISO: Notify user space about failed bis connections") > Signed-off-by: Sungwoo Kim <iam@sung-woo.kim> > --- > v1 -> v2: > - add a Fixes tag > - make the commit message concise > v2 -> v3: > - fix a wrong Fixes tag format > > [...] Here is the summary with links: - [v3] Bluetooth: HCI: Fix potential null-ptr-deref https://git.kernel.org/bluetooth/bluetooth-next/c/5c7d0f260187 You are awesome, thank you!
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c index 4a27e4a17..d72d238c1 100644 --- a/net/bluetooth/hci_event.c +++ b/net/bluetooth/hci_event.c @@ -7037,6 +7037,8 @@ static void hci_le_big_sync_established_evt(struct hci_dev *hdev, void *data, u16 handle = le16_to_cpu(ev->bis[i]); bis = hci_conn_hash_lookup_handle(hdev, handle); + if (!bis) + continue; set_bit(HCI_CONN_BIG_SYNC_FAILED, &bis->flags); hci_connect_cfm(bis, ev->status);
Fix potential null-ptr-deref in hci_le_big_sync_established_evt(). Fixes: f777d8827817 ("Bluetooth: ISO: Notify user space about failed bis connections") Signed-off-by: Sungwoo Kim <iam@sung-woo.kim> --- v1 -> v2: - add a Fixes tag - make the commit message concise v2 -> v3: - fix a wrong Fixes tag format net/bluetooth/hci_event.c | 2 ++ 1 file changed, 2 insertions(+)