diff mbox series

[v2] spi: mux: Fix master controller settings after mux select

Message ID 20240424111647.81286-1-heikki.keranen@bittium.com
State Superseded
Headers show
Series [v2] spi: mux: Fix master controller settings after mux select | expand

Commit Message

Heikki Keranen April 24, 2024, 11:16 a.m. UTC 
In some cases SPI child devices behind spi-mux require different
settings like: max_speed_hz, mode and bits_per_word.

Typically the slave device driver puts the settings in place and calls
spi_setup() once during probe and assumes they stay in place for all
following spi transfers.

However spi-mux forwarded spi_setup() -call to SPI master driver only
when slave driver calls spi_setup(). If second slave device was
accessed meanwhile and that driver called spi_setup(), the
settings did not change back to the first spi device.
In case of wrong max_speed_hz this caused spi trasfers to fail.

This commit adds spi_setup() call after mux is changed. This way
the right device specific parameters are set to the master driver.

The fix has been tested by using custom hardware and debugging
spi master driver speed settings.

Co-developed-by: Petri Tauriainen <petri.tauriainen@bittium.com>
Signed-off-by: Petri Tauriainen <petri.tauriainen@bittium.com>
Signed-off-by: Heikki Keranen <heikki.keranen@bittium.com>
---
Changes in v2:
- fixed Co-authored-by -> Co-developed-by
- added Signed-off-by for co-developer
  both suggested by Andy Shevchenko, thanks!

 drivers/spi/spi-mux.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/drivers/spi/spi-mux.c b/drivers/spi/spi-mux.c
index bd988f53753e..5d72e3d59df8 100644
--- a/drivers/spi/spi-mux.c
+++ b/drivers/spi/spi-mux.c
@@ -68,6 +68,8 @@  static int spi_mux_select(struct spi_device *spi)
 
 	priv->current_cs = spi_get_chipselect(spi, 0);
 
+	spi_setup(priv->spi);
+
 	return 0;
 }