| Message ID | 20240412-axi-spi-engine-version-printf-v1-1-95e1e842c1a6@baylibre.com |
|---|---|
| State | Accepted |
| Commit | 0064db9ce4aa7cc794e6f4aed60dee0f94fc9bcf |
| Headers | show |
| Series | spi: axi-spi-engine: fix version format string | expand |
On Fri, 12 Apr 2024 17:52:48 -0500, David Lechner wrote: > The version format string in the AXI SPI Engine driver was probably > intended to print the version number in the same format as the DT > compatible string (e.g. 1.00.a). However, the version just uses > semantic versioning so formatting the patch number as a character > is not correct and would result in printing control characters for > patch numbers less than 32. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: axi-spi-engine: fix version format string commit: 0064db9ce4aa7cc794e6f4aed60dee0f94fc9bcf All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-engine.c index 7cc219d78551..e358ac5b4509 100644 --- a/drivers/spi/spi-axi-spi-engine.c +++ b/drivers/spi/spi-axi-spi-engine.c @@ -623,7 +623,7 @@ static int spi_engine_probe(struct platform_device *pdev) version = readl(spi_engine->base + ADI_AXI_REG_VERSION); if (ADI_AXI_PCORE_VER_MAJOR(version) != 1) { - dev_err(&pdev->dev, "Unsupported peripheral version %u.%u.%c\n", + dev_err(&pdev->dev, "Unsupported peripheral version %u.%u.%u\n", ADI_AXI_PCORE_VER_MAJOR(version), ADI_AXI_PCORE_VER_MINOR(version), ADI_AXI_PCORE_VER_PATCH(version));
The version format string in the AXI SPI Engine driver was probably intended to print the version number in the same format as the DT compatible string (e.g. 1.00.a). However, the version just uses semantic versioning so formatting the patch number as a character is not correct and would result in printing control characters for patch numbers less than 32. Fixes: b1353d1c1d45 ("spi: Add Analog Devices AXI SPI Engine controller support") Signed-off-by: David Lechner <dlechner@baylibre.com> --- drivers/spi/spi-axi-spi-engine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 637ced031d3c490f0c37c1e826574f39909647a5 change-id: 20240412-axi-spi-engine-version-printf-c5204b657a9f