| Message ID | 20161021212737.15974-20-lersek@redhat.com |
|---|---|
| State | Accepted |
| Commit | 17dc8ebc0d76831cb9f7b0e32ccb87efa116b3ce |
| Headers | show |
Ard, On 10/21/16 23:27, Laszlo Ersek wrote: > At this point no code in ArmVirtPkg (and apparently no code outside of > ArmVirtPkg that the ArmVirt binaries depend on) uses the deprecated APIs, > so we can disable them in the common platform DSC include file: > > BaseLib: > - StrCpy > - StrnCpy > - StrCat > - StrnCat > - UnicodeStrToAsciiStr > - AsciiStrCpy > - AsciiStrnCpy > - AsciiStrCat > - AsciiStrnCat > - AsciiStrToUnicodeStr > > PcdLib: > - PcdSet8 > - PcdSet16 > - PcdSet32 > - PcdSet64 > - PcdSetPtr > - PcdSetBool > - PcdSetEx8 > - PcdSetEx16 > - PcdSetEx32 > - PcdSetEx64 > - PcdSetExPtr > - PcdSetExBool > > UefiLib: > - GetVariable > - GetEfiGlobalVariable > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <lersek@redhat.com> > --- > > Notes: > not build-tested with RVCT > > ArmVirtPkg/ArmVirt.dsc.inc | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index c071988ad8f5..dbd6678accde 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -246,6 +246,12 @@ [BuildOptions] > > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > > + # > + # Disable deprecated APIs. > + # > + RVCT:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES > + GCC:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES > + > ################################################################################ > # > # Pcd Section - list of all EDK II PCD Entries defined by this Platform > Can you please give an R-b for this too? Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 25 October 2016 at 09:25, Laszlo Ersek <lersek@redhat.com> wrote: > Ard, > > On 10/21/16 23:27, Laszlo Ersek wrote: >> At this point no code in ArmVirtPkg (and apparently no code outside of >> ArmVirtPkg that the ArmVirt binaries depend on) uses the deprecated APIs, >> so we can disable them in the common platform DSC include file: >> >> BaseLib: >> - StrCpy >> - StrnCpy >> - StrCat >> - StrnCat >> - UnicodeStrToAsciiStr >> - AsciiStrCpy >> - AsciiStrnCpy >> - AsciiStrCat >> - AsciiStrnCat >> - AsciiStrToUnicodeStr >> >> PcdLib: >> - PcdSet8 >> - PcdSet16 >> - PcdSet32 >> - PcdSet64 >> - PcdSetPtr >> - PcdSetBool >> - PcdSetEx8 >> - PcdSetEx16 >> - PcdSetEx32 >> - PcdSetEx64 >> - PcdSetExPtr >> - PcdSetExBool >> >> UefiLib: >> - GetVariable >> - GetEfiGlobalVariable >> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Laszlo Ersek <lersek@redhat.com> >> --- >> >> Notes: >> not build-tested with RVCT >> >> ArmVirtPkg/ArmVirt.dsc.inc | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc >> index c071988ad8f5..dbd6678accde 100644 >> --- a/ArmVirtPkg/ArmVirt.dsc.inc >> +++ b/ArmVirtPkg/ArmVirt.dsc.inc >> @@ -246,6 +246,12 @@ [BuildOptions] >> >> GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG >> >> + # >> + # Disable deprecated APIs. >> + # >> + RVCT:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES >> + GCC:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES >> + >> ################################################################################ >> # >> # Pcd Section - list of all EDK II PCD Entries defined by this Platform >> > > Can you please give an R-b for this too? > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> However, I am still a bit uneasy regarding the lack of explicit confirmation that it is the responsibility of the person who moves functions under a '#ifndef DISABLE_NEW_DEPRECATED_INTERFACES' to ensure that all references have been removed from the *entire* codebase, not just the intel bits. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc index c071988ad8f5..dbd6678accde 100644 --- a/ArmVirtPkg/ArmVirt.dsc.inc +++ b/ArmVirtPkg/ArmVirt.dsc.inc @@ -246,6 +246,12 @@ [BuildOptions] GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG + # + # Disable deprecated APIs. + # + RVCT:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES + GCC:*_*_*_CC_FLAGS = -DDISABLE_NEW_DEPRECATED_INTERFACES + ################################################################################ # # Pcd Section - list of all EDK II PCD Entries defined by this Platform
At this point no code in ArmVirtPkg (and apparently no code outside of ArmVirtPkg that the ArmVirt binaries depend on) uses the deprecated APIs, so we can disable them in the common platform DSC include file: BaseLib: - StrCpy - StrnCpy - StrCat - StrnCat - UnicodeStrToAsciiStr - AsciiStrCpy - AsciiStrnCpy - AsciiStrCat - AsciiStrnCat - AsciiStrToUnicodeStr PcdLib: - PcdSet8 - PcdSet16 - PcdSet32 - PcdSet64 - PcdSetPtr - PcdSetBool - PcdSetEx8 - PcdSetEx16 - PcdSetEx32 - PcdSetEx64 - PcdSetExPtr - PcdSetExBool UefiLib: - GetVariable - GetEfiGlobalVariable Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Laszlo Ersek <lersek@redhat.com> --- Notes: not build-tested with RVCT ArmVirtPkg/ArmVirt.dsc.inc | 6 ++++++ 1 file changed, 6 insertions(+) -- 2.9.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel