| Message ID | 20240406135106.16821-1-hdegoede@redhat.com |
|---|---|
| State | Accepted |
| Commit | fd6790ea67ee14b39b5b9ca1cf7a7f77bca56206 |
| Headers | show |
| Series | [resend] Bluetooth: hci_bcm: Limit bcm43455 baudrate to 2000000 | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=842037 ---Test result--- Test Summary: CheckPatch PASS 4.80 seconds GitLint PASS 0.23 seconds SubjectPrefix PASS 0.07 seconds BuildKernel PASS 29.60 seconds CheckAllWarning PASS 32.93 seconds CheckSparse PASS 37.98 seconds CheckSmatch FAIL 34.61 seconds BuildKernel32 PASS 29.01 seconds TestRunnerSetup PASS 516.94 seconds TestRunner_l2cap-tester PASS 18.28 seconds TestRunner_iso-tester PASS 28.37 seconds TestRunner_bnep-tester PASS 4.62 seconds TestRunner_mgmt-tester PASS 108.48 seconds TestRunner_rfcomm-tester PASS 7.21 seconds TestRunner_sco-tester PASS 14.88 seconds TestRunner_ioctl-tester PASS 7.63 seconds TestRunner_mesh-tester PASS 5.74 seconds TestRunner_smp-tester PASS 6.69 seconds TestRunner_userchan-tester PASS 4.80 seconds IncrementalBuild PASS 27.70 seconds Details ############################## Test: CheckSmatch - FAIL Desc: Run smatch tool with source Output: Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139 make[4]: *** Deleting file 'net/bluetooth/hci_core.o' make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: net] Error 2 make[2]: *** Waiting for unfinished jobs.... Segmentation fault (core dumped) make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139 make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o' make[4]: *** Waiting for unfinished jobs.... make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2 make[2]: *** [scripts/Makefile.build:485: drivers] Error 2 make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2 make: *** [Makefile:240: __sub-make] Error 2 --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sat, 6 Apr 2024 15:51:06 +0200 you wrote: > Like the bcm43430a0 the bcm43455 BT does not support the 0xfc45 command > to set the UART clock to 48 MHz and because of this it does not work > at 4000000 baud. > > These chips are found on ACPI/x86 devices where the operating baudrate > does not come from the firmware but is hardcoded at 4000000, which does > not work. > > [...] Here is the summary with links: - [resend] Bluetooth: hci_bcm: Limit bcm43455 baudrate to 2000000 https://git.kernel.org/bluetooth/bluetooth-next/c/fd6790ea67ee You are awesome, thank you!
diff --git a/drivers/bluetooth/hci_bcm.c b/drivers/bluetooth/hci_bcm.c index 874d23089b39..85471be0c71a 100644 --- a/drivers/bluetooth/hci_bcm.c +++ b/drivers/bluetooth/hci_bcm.c @@ -1487,7 +1487,7 @@ static const struct acpi_device_id bcm_acpi_match[] = { { "BCM2EA1" }, { "BCM2EA2", (long)&bcm43430_device_data }, { "BCM2EA3", (long)&bcm43430_device_data }, - { "BCM2EA4" }, + { "BCM2EA4", (long)&bcm43430_device_data }, /* bcm43455 */ { "BCM2EA5" }, { "BCM2EA6" }, { "BCM2EA7" },
Like the bcm43430a0 the bcm43455 BT does not support the 0xfc45 command to set the UART clock to 48 MHz and because of this it does not work at 4000000 baud. These chips are found on ACPI/x86 devices where the operating baudrate does not come from the firmware but is hardcoded at 4000000, which does not work. Make the driver_data for the "BCM2EA4" ACPI HID which is used for the bcm43455 BT point to bcm43430_device_data which limits the baudrate to 2000000. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/bluetooth/hci_bcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)