| Message ID | 20240404160649.967-1-bavishimithil@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] dt-bindings: omap-mcpdm: Convert to DT schema | expand |
On Fri, Apr 5, 2024 at 9:27 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 05/04/2024 16:48, Mithil wrote: > > So sorry about the 2nd patch being sent as a new mail, here is a new > > patch with the changes as suggested > > > >> Please use subject prefixes matching the subsystem > > Changed the patch name to match the folder history. > > Nothing improved. What the history tells you? > Referred to "ASoC: dt-bindings: rt1015: Convert to dtschema" Not really sure what else I should change. > > > >> Is it your full name? > > Fixed it, my apologies. > > > >> Filename like compatible. > > Fixed. > > Still not, compatible is omap4. > Sorry, seems like I was sending the old file again. Will fix this. > > > >> Please open existing bindings and look how it is done there. > > Changed it, is it fine now? > > You mean v2? I have no clue to what you are responding here, but no, v2 > did not improve much. > Again, could you guide me to what needs to be done? Description for reg should be fine as this is how it is done in other files as well. Interrupts and hwmods use maxItems now. Changed nodename to be generic in example as well. Those were the suggested changes previously. Best regards, Mithil
On Fri, Apr 5, 2024 at 10:38 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 05/04/2024 18:29, Mithil wrote: > > On Fri, Apr 5, 2024 at 9:27 PM Krzysztof Kozlowski > > <krzysztof.kozlowski@linaro.org> wrote: > >> > >> On 05/04/2024 16:48, Mithil wrote: > >>> So sorry about the 2nd patch being sent as a new mail, here is a new > >>> patch with the changes as suggested > >>> > >>>> Please use subject prefixes matching the subsystem > >>> Changed the patch name to match the folder history. > >> > >> Nothing improved. What the history tells you? > >> > > > > Referred to "ASoC: dt-bindings: rt1015: Convert to dtschema" > > Not really sure what else I should change. > > But the subject you wrote here is "dt-bindings: omap-mcpdm: Convert to > DT schema"? > > Where is the ASoC? > I did change it, will send the patch again. > > reg is not correct. Please point me to files doing that way, so I can > fix them. > > You need items with description. > Documentation/devicetree/bindings/sound/fsl,imx-asrc.yaml I referred here for the description, but will add items for the 2 regs > > Interrupts and hwmods use maxItems now. > > hwmods lost description, why? Seems self explanatory. > > Changed nodename to be generic in example as well. > > "mcpdm" does not feel generic. What is mcpdm? Google finds nothing. > Maybe just "pdm"? > Multichannel PDM Controller. Kept it like that since the node is also called as mcpdm in the devicetree. Calling it pdm might cause confusion. Best Regards, Mithil
Hello, Is the patch better now? I'd still like to learn from where i did the mistakes (which seem very silly now) Best Regards, Mithil
On 12/04/2024 16:16, Mithil wrote: > Hello, > Is the patch better now? I'd still like to learn from where i did the > mistakes (which seem very silly now) I do not recall any new patch from you. Please follow submitting patches document. Each patch is a new submission (new, not reply to something), with versioning, with changelog under ---. For example generated with `git format-patch -v3 -1`. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt b/Documentation/devicetree/bindings/sound/omap-mcpdm.txt deleted file mode 100644 index ff98a0cb5..000000000 --- a/Documentation/devicetree/bindings/sound/omap-mcpdm.txt +++ /dev/null @@ -1,30 +0,0 @@ -* Texas Instruments OMAP4+ McPDM - -Required properties: -- compatible: "ti,omap4-mcpdm" -- reg: Register location and size as an array: - <MPU access base address, size>, - <L3 interconnect address, size>; -- interrupts: Interrupt number for McPDM -- ti,hwmods: Name of the hwmod associated to the McPDM -- clocks: phandle for the pdmclk provider, likely <&twl6040> -- clock-names: Must be "pdmclk" - -Example: - -mcpdm: mcpdm@40132000 { - compatible = "ti,omap4-mcpdm"; - reg = <0x40132000 0x7f>, /* MPU private access */ - <0x49032000 0x7f>; /* L3 Interconnect */ - interrupts = <0 112 0x4>; - interrupt-parent = <&gic>; - ti,hwmods = "mcpdm"; -}; - -In board DTS file the pdmclk needs to be added: - -&mcpdm { - clocks = <&twl6040>; - clock-names = "pdmclk"; - status = "okay"; -}; diff --git a/Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml b/Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml new file mode 100644 index 000000000..4d5d37e98 --- /dev/null +++ b/Documentation/devicetree/bindings/sound/ti,omap-mcpdm.yaml @@ -0,0 +1,59 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/ti,omap-mcpdm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OMAP McPDM + +maintainers: + - Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> + +description: + OMAP ALSA SoC DAI driver using McPDM port used by TWL6040 + +properties: + compatible: + const: ti,omap4-mcpdm + + reg: + description: + Register location and size as an array + <MPU access base address, size>, + <L3 interconnect address, size>; + + interrupts: + maxItems: 1 + + ti,hwmods: + maxItems: 1 + + clocks: + description: phandle for the pdmclk provider, likely <&twl6040> + + clock-names: + description: Must be "pdmclk" + + +required: + - compatible + - reg + - interrupts + - ti,hwmods + - clocks + - clock-names + +additionalProperties: false + +examples: + - | + mcpdm@0 { + compatible = "ti,omap4-mcpdm"; + reg = <0x40132000 0x7f>, /* MPU private access */ + <0x49032000 0x7f>; /* L3 Interconnect */ + interrupts = <0 112 0x4>; + interrupt-parent = <&gic>; + ti,hwmods = "mcpdm"; + clocks = <&twl6040>; + clock-names = "pdmclk"; + };