diff mbox series

[02/32] accel/tcg: Hide in_same_page outside of a target-specific context

Message ID 20240405102459.462551-3-richard.henderson@linaro.org
State Superseded
Headers show
Series accel/tcg: Improve disassembly for target and plugin | expand

Commit Message

Richard Henderson April 5, 2024, 10:24 a.m. UTC 
While there are other methods that could be used to replace
TARGET_PAGE_MASK, the function is not really required outside
the context of target-specific translation.

This makes the header usable by target independent code.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 include/exec/translator.h | 2 ++
 1 file changed, 2 insertions(+)

Comments

Philippe Mathieu-Daudé April 5, 2024, 12:35 p.m. UTC | #1 
On 5/4/24 12:24, Richard Henderson wrote:
> While there are other methods that could be used to replace
> TARGET_PAGE_MASK, the function is not really required outside
> the context of target-specific translation.
> 
> This makes the header usable by target independent code.
> 
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>   include/exec/translator.h | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff mbox series

Patch

diff --git a/include/exec/translator.h b/include/exec/translator.h
index 29804de92e..185ab5c374 100644
--- a/include/exec/translator.h
+++ b/include/exec/translator.h
@@ -230,6 +230,7 @@  translator_ldq_swap(CPUArchState *env, DisasContextBase *db,
  */
 void translator_fake_ldb(uint8_t insn8, vaddr pc);
 
+#ifdef NEED_CPU_H
 /*
  * Return whether addr is on the same page as where disassembly started.
  * Translators can use this to enforce the rule that only single-insn
@@ -239,5 +240,6 @@  static inline bool is_same_page(const DisasContextBase *db, vaddr addr)
 {
     return ((addr ^ db->pc_first) & TARGET_PAGE_MASK) == 0;
 }
+#endif
 
 #endif /* EXEC__TRANSLATOR_H */