| Message ID | 20240402103406.3638821-3-quic_varada@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add interconnect driver for IPQ9574 SoC | expand |
On Tue, 2 Apr 2024 at 13:34, Varadarajan Narayanan <quic_varada@quicinc.com> wrote: > > drivers/clk/qcom/common.c uses devm_icc_clk_register under > IS_ENABLED(CONFIG_INTERCONNECT_CLK). However, in kernel bot > random config build test, with the following combination > > CONFIG_COMMON_CLK_QCOM=y > and > CONFIG_INTERCONNECT_CLK=m > > the following error is seen as devm_icc_clk_register is in a > module and being referenced from vmlinux. > > powerpc64-linux-ld: drivers/clk/qcom/common.o: in function `qcom_cc_really_probe': > >> common.c:(.text+0x980): undefined reference to `devm_icc_clk_register' > > Hence, ensure INTERCONNECT_CLK is not selected as a module. NAK. Please use `depends on INTERCONNECT_CLK || !INTERCONNECT_CLK` in your Kconfig dependencies. > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202404012258.MFriF5BV-lkp@intel.com/ > Fixes: 0ac2a08f42ce ("interconnect: add clk-based icc provider support") > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com> > --- > drivers/interconnect/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig > index 5faa8d2aecff..f44be5469382 100644 > --- a/drivers/interconnect/Kconfig > +++ b/drivers/interconnect/Kconfig > @@ -16,7 +16,6 @@ source "drivers/interconnect/qcom/Kconfig" > source "drivers/interconnect/samsung/Kconfig" > > config INTERCONNECT_CLK > - tristate > depends on COMMON_CLK > help > Support for wrapping clocks into the interconnect nodes. > -- > 2.34.1 > -- With best wishes Dmitry
On 2.04.2024 12:39 PM, Dmitry Baryshkov wrote: > On Tue, 2 Apr 2024 at 13:34, Varadarajan Narayanan > <quic_varada@quicinc.com> wrote: >> >> drivers/clk/qcom/common.c uses devm_icc_clk_register under >> IS_ENABLED(CONFIG_INTERCONNECT_CLK). However, in kernel bot >> random config build test, with the following combination >> >> CONFIG_COMMON_CLK_QCOM=y >> and >> CONFIG_INTERCONNECT_CLK=m >> >> the following error is seen as devm_icc_clk_register is in a >> module and being referenced from vmlinux. >> >> powerpc64-linux-ld: drivers/clk/qcom/common.o: in function `qcom_cc_really_probe': >> >> common.c:(.text+0x980): undefined reference to `devm_icc_clk_register' >> >> Hence, ensure INTERCONNECT_CLK is not selected as a module. > > NAK. Please use `depends on INTERCONNECT_CLK || !INTERCONNECT_CLK` in > your Kconfig dependencies. Should icc-clk ever be built as a module? It really seems like it should be a part of the core framework.. And dependency management would be easier Konrad
diff --git a/drivers/interconnect/Kconfig b/drivers/interconnect/Kconfig index 5faa8d2aecff..f44be5469382 100644 --- a/drivers/interconnect/Kconfig +++ b/drivers/interconnect/Kconfig @@ -16,7 +16,6 @@ source "drivers/interconnect/qcom/Kconfig" source "drivers/interconnect/samsung/Kconfig" config INTERCONNECT_CLK - tristate depends on COMMON_CLK help Support for wrapping clocks into the interconnect nodes.