| Message ID | 20240326010905.2147-1-baojun.xu@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver | expand |
Hi Gergo, Answer in line: > From: Gergo Koteles <soyer@irl.hu> > Sent: 27 March 2024 18:02 > To: Xu, Baojun; tiwai@suse.de > Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; lgirdwood@gmail.com; perex@perex.cz; pierre-louis.bossart@linux.intel.com; Lu, Kevin; 13916275206@139.com; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; liam.r.girdwood@intel.com; yung-chuan.liao@linux.intel.com; broonie@kernel.org > Subject: [EXTERNAL] Re: [PATCH v1 7/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver > > Hi Baojun, On Tue, 2024-03-26 at 09: 09 +0800, Baojun Xu wrote: > Firmware binary load lib code for tas2781 spi driver. > > Signed-off-by: Baojun Xu <baojun. xu@ ti. com> > --- > sound/pci/hda/tas2781_spi_fwlib. c | 2374 +++++++++++++++++++++++++++++ > ZjQcmQRYFpfptBannerStart > This message was sent from outside of Texas Instruments. > Do not click links or open attachments unless you recognize the source of this email and know the content is safe. > > ZjQcmQRYFpfptBannerEnd > > Hi Baojun, > > On Tue, 2024-03-26 at 09:09 +0800, Baojun Xu wrote: > > Firmware binary load lib code for tas2781 spi driver. > > > > Signed-off-by: Baojun Xu <baojun.xu@ti.com> > > --- > > sound/pci/hda/tas2781_spi_fwlib.c | 2374 +++++++++++++++++++++++++++++ > > 1 file changed, 2374 insertions(+) > > create mode 100644 sound/pci/hda/tas2781_spi_fwlib.c > > > > Is this firmware loading logic the same as the already merged tas2781- > fmwlib? If yes, why don't you use that? It's almost same, but one firmware was loaded in I2C mode as one I2C device was probed, and operate slavers by address. And with SPI mode, we probe two SPI devices in current case, so will load two firmware binary, and some operation need to be processed as special case, for example, under SPI, read need one byte shifted if page number is large than 1. > > Thanks, > Gergo > >
> From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > Sent: 26 March 2024 23:05 > To: Xu, Baojun; tiwai@suse.de > Cc: robh+dt@kernel.org; andriy.shevchenko@linux.intel.com; lgirdwood@gmail.com; perex@perex.cz; Lu, Kevin; 13916275206@139.com; alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; liam.r.girdwood@intel.com; yung-chuan.liao@linux.intel.com; broonie@kernel.org; soyer@irl.hu > Subject: [EXTERNAL] Re: [PATCH v1 6/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver > > > +enum device_catlog_id { > > catalog? > > > + HP = 0, > > + OTHERS > > +}; > > Is there not a better way to identify solutions? > You have ACPI IDs, no? It support HP platform now only, will add other later. Best Regards Jim
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 7c157bf92..226bd9097 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -1765,6 +1765,7 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) {"CSC3557", }, {"INT33FE", }, {"INT3515", }, + {"TXNW2781", }, /* Non-conforming _HID for Cirrus Logic already released */ {"CLSA0100", }, {"CLSA0101", },
Add TXNW2781 support in smi. Signed-off-by: Baojun Xu <baojun.xu@ti.com> --- drivers/acpi/scan.c | 1 + 1 file changed, 1 insertion(+)