| Message ID | 20240328022231.3649741-4-peteryin.openbmc@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | drivers: watchdog: ast2500 and ast2600 support bootstatus | expand |
On Thu, Mar 28, 2024 at 10:22:30AM +0800, Peter Yin wrote: > To use the SCU register to obtain reset flags for supporting > bootstatus. > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> > --- > Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > index 3208adb3e52e..80a1f58b5a2e 100644 > --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > @@ -8,6 +8,8 @@ Required properties: > > - reg: physical base address of the controller and length of memory mapped > region > + - aspeed,scu: a reference to the System Control Unit node of the Aspeed > + SOC. You cannot add new required properties as that is an ABI break. If there's only 1 SCU instance, you can just fetch its node by compatible with no DT change. What's the plan for converting this binding to schema? This is the 2nd new property in 6 months. Rob
On Mon, 2024-04-01 at 08:56 -0500, Rob Herring wrote: > On Thu, Mar 28, 2024 at 10:22:30AM +0800, Peter Yin wrote: > > To use the SCU register to obtain reset flags for supporting > > bootstatus. > > > > Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> > > --- > > Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > > index 3208adb3e52e..80a1f58b5a2e 100644 > > --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > > +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt > > @@ -8,6 +8,8 @@ Required properties: > > > > - reg: physical base address of the controller and length of memory mapped > > region > > + - aspeed,scu: a reference to the System Control Unit node of the Aspeed > > + SOC. > > You cannot add new required properties as that is an ABI break. > > If there's only 1 SCU instance, you can just fetch its node by > compatible with no DT change. > > What's the plan for converting this binding to schema? This is the 2nd > new property in 6 months. I had a patch converting it in a local branch which I've now sent: https://lore.kernel.org/all/20240402120118.282035-1-andrew@codeconstruct.com.au/ Perhaps we can pull it into this series? Andrew
Thanks, I can wait you update it and send a new version for wdt driver. Andrew Jeffery 於 4/2/24 20:09 寫道: > I had a patch converting it in a local branch which I've now sent: > > https://lore.kernel.org/all/20240402120118.282035-1-andrew@codeconstruct.com.au/ > > Perhaps we can pull it into this series?
On Wed, 2024-04-03 at 17:18 +0800, PeterYin wrote:
> Thanks, I can wait you update it and send a new version for wdt driver.
I've sent v2:
https://lore.kernel.org/linux-watchdog/20240403020439.418788-1-andrew@codeconstruct.com.au/
Rob's okay with it:
https://lore.kernel.org/linux-watchdog/20240403171321.GA3996007-robh@kernel.org/
Feel free to address his comment there if you integrate it into your
series, though make sure to add his tag, keep my authorship, and append
your own S-o-b if you do.
Andrew
diff --git a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt index 3208adb3e52e..80a1f58b5a2e 100644 --- a/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt +++ b/Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt @@ -8,6 +8,8 @@ Required properties: - reg: physical base address of the controller and length of memory mapped region + - aspeed,scu: a reference to the System Control Unit node of the Aspeed + SOC. Optional properties: @@ -62,6 +64,7 @@ Examples: reg = <0x1e785000 0x1c>; aspeed,reset-type = "system"; aspeed,external-signal; + aspeed,scu = <&syscon>; }; #include <dt-bindings/watchdog/aspeed-wdt.h> @@ -70,4 +73,5 @@ Examples: reg = <0x1e785040 0x40>; aspeed,reset-mask = <AST2600_WDT_RESET1_DEFAULT (AST2600_WDT_RESET2_DEFAULT & ~AST2600_WDT_RESET2_LPC)>; + aspeed,scu = <&syscon>; };
To use the SCU register to obtain reset flags for supporting bootstatus. Signed-off-by: Peter Yin <peteryin.openbmc@gmail.com> --- Documentation/devicetree/bindings/watchdog/aspeed-wdt.txt | 4 ++++ 1 file changed, 4 insertions(+)