| Message ID | 20240327081508.36747-3-tony@atomide.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Updates for ti-sysc interconnect target driver | expand |
On Mar 27, 2024 at 10:15:05 +0200, Tony Lindgren wrote: > The ti-sysc driver is missing coprights and description, let's add > those. > > Signed-off-by: Tony Lindgren <tony@atomide.com> > --- > drivers/bus/ti-sysc.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > --- a/drivers/bus/ti-sysc.c > +++ b/drivers/bus/ti-sysc.c > @@ -1,6 +1,17 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > * ti-sysc.c - Texas Instruments sysc interconnect target driver > + * > + * TI SoCs have an interconnect target wrapper IP for many devices. The wrapper > + * IP manages clock gating, resets, and PM capabilities for the connected devices. > + * > + * Copyright (C) 2017-2024 Texas Instruments Incorporated - https://www.ti.com/ > + * > + * Many features are based on the earlier omap_hwmod arch code with thanks to all > + * the people who developed and debugged the code over the years: > + * > + * Copyright (C) 2009-2011 Nokia Corporation > + * Copyright (C) 2011-2012 Texas Instruments, Inc. +Nishant I am no expert on the copyrights part of it, but who gets copyright from 2012 - 2017? Also, for TI should we stick to this format as you did above? Copyright (C) 2011-2024 Texas Instruments Incorporated perhaps? But otherwise, Reviewed-by: Dhruva Gole <d-gole@ti.com>
On Thu, Mar 28, 2024 at 04:49:07PM +0530, Dhruva Gole wrote: > On Mar 27, 2024 at 10:15:05 +0200, Tony Lindgren wrote: > > The ti-sysc driver is missing coprights and description, let's add > > those. > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > --- > > drivers/bus/ti-sysc.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > > --- a/drivers/bus/ti-sysc.c > > +++ b/drivers/bus/ti-sysc.c > > @@ -1,6 +1,17 @@ > > // SPDX-License-Identifier: GPL-2.0 > > /* > > * ti-sysc.c - Texas Instruments sysc interconnect target driver > > + * > > + * TI SoCs have an interconnect target wrapper IP for many devices. The wrapper > > + * IP manages clock gating, resets, and PM capabilities for the connected devices. > > + * > > + * Copyright (C) 2017-2024 Texas Instruments Incorporated - https://www.ti.com/ > > + * > > + * Many features are based on the earlier omap_hwmod arch code with thanks to all > > + * the people who developed and debugged the code over the years: > > + * > > + * Copyright (C) 2009-2011 Nokia Corporation > > + * Copyright (C) 2011-2012 Texas Instruments, Inc. > > +Nishant > > I am no expert on the copyrights part of it, but who gets copyright from > 2012 - 2017? If there are no changes in those years, what exactly are you attempting to copyright for those years? Please talk to your corporate copyright lawyers about this. I'm sure there is a class you can take from them to explain all of this. If not, there's a free one online from the Linux Foundation that you might want to take instead. thanks, greg k-h
* Dhruva Gole <d-gole@ti.com> [240328 11:19]: > On Mar 27, 2024 at 10:15:05 +0200, Tony Lindgren wrote: > > The ti-sysc driver is missing coprights and description, let's add > > those. > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > --- > > drivers/bus/ti-sysc.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > > --- a/drivers/bus/ti-sysc.c > > +++ b/drivers/bus/ti-sysc.c > > @@ -1,6 +1,17 @@ > > // SPDX-License-Identifier: GPL-2.0 > > /* > > * ti-sysc.c - Texas Instruments sysc interconnect target driver > > + * > > + * TI SoCs have an interconnect target wrapper IP for many devices. The wrapper > > + * IP manages clock gating, resets, and PM capabilities for the connected devices. > > + * > > + * Copyright (C) 2017-2024 Texas Instruments Incorporated - https://www.ti.com/ > > + * > > + * Many features are based on the earlier omap_hwmod arch code with thanks to all > > + * the people who developed and debugged the code over the years: > > + * > > + * Copyright (C) 2009-2011 Nokia Corporation > > + * Copyright (C) 2011-2012 Texas Instruments, Inc. > > +Nishant > > I am no expert on the copyrights part of it, but who gets copyright from > 2012 - 2017? Well this particular driver did not exist until 2017 :) But for the earlier hwmod arch code reference above, we could make it 2011-2024. > Also, for TI should we stick to this format as you did above? > Copyright (C) 2011-2024 Texas Instruments Incorporated > perhaps? Sure that works for me. > But otherwise, > Reviewed-by: Dhruva Gole <d-gole@ti.com> Thanks, Tony
On Mar 28, 2024 at 12:36:22 +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 28, 2024 at 04:49:07PM +0530, Dhruva Gole wrote: > > On Mar 27, 2024 at 10:15:05 +0200, Tony Lindgren wrote: > > > The ti-sysc driver is missing coprights and description, let's add > > > those. > > > > > > Signed-off-by: Tony Lindgren <tony@atomide.com> > > > --- > > > drivers/bus/ti-sysc.c | 11 +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c > > > --- a/drivers/bus/ti-sysc.c > > > +++ b/drivers/bus/ti-sysc.c > > > @@ -1,6 +1,17 @@ > > > // SPDX-License-Identifier: GPL-2.0 > > > /* > > > * ti-sysc.c - Texas Instruments sysc interconnect target driver > > > + * > > > + * TI SoCs have an interconnect target wrapper IP for many devices. The wrapper > > > + * IP manages clock gating, resets, and PM capabilities for the connected devices. > > > + * > > > + * Copyright (C) 2017-2024 Texas Instruments Incorporated - https://www.ti.com/ > > > + * > > > + * Many features are based on the earlier omap_hwmod arch code with thanks to all > > > + * the people who developed and debugged the code over the years: > > > + * > > > + * Copyright (C) 2009-2011 Nokia Corporation > > > + * Copyright (C) 2011-2012 Texas Instruments, Inc. > > > > +Nishant > > > > I am no expert on the copyrights part of it, but who gets copyright from > > 2012 - 2017? > > If there are no changes in those years, what exactly are you attempting > to copyright for those years? Oops, should've checked git log. I think 2017 makes sense then. However the 2011-2012 copyright format comment still stands. > > Please talk to your corporate copyright lawyers about this. I'm sure > there is a class you can take from them to explain all of this. If not, > there's a free one online from the Linux Foundation that you might want > to take instead. Thanks, will take a look!
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -1,6 +1,17 @@ // SPDX-License-Identifier: GPL-2.0 /* * ti-sysc.c - Texas Instruments sysc interconnect target driver + * + * TI SoCs have an interconnect target wrapper IP for many devices. The wrapper + * IP manages clock gating, resets, and PM capabilities for the connected devices. + * + * Copyright (C) 2017-2024 Texas Instruments Incorporated - https://www.ti.com/ + * + * Many features are based on the earlier omap_hwmod arch code with thanks to all + * the people who developed and debugged the code over the years: + * + * Copyright (C) 2009-2011 Nokia Corporation + * Copyright (C) 2011-2012 Texas Instruments, Inc. */ #include <linux/io.h>
The ti-sysc driver is missing coprights and description, let's add those. Signed-off-by: Tony Lindgren <tony@atomide.com> --- drivers/bus/ti-sysc.c | 11 +++++++++++ 1 file changed, 11 insertions(+)