| Message ID | 20240326-topic-rpm_icc_qos_cleanup-v1-2-357e736792be@linaro.org |
|---|---|
| State | Accepted |
| Commit | 230d05b1179f6ce6f8dc8a2b99eba92799ac22d7 |
| Headers | show |
| Series | Rework rpm-icc QoS settings | expand |
On Tue, Mar 26, 2024 at 08:42:33PM +0100, Konrad Dybcio wrote: > The value was wrong, resulting in misprogramming of the hardware. > Fix it. > > Fixes: 1a14b1ac3935 ("interconnect: qcom: Add QCM2290 driver support") > Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> > --- > drivers/interconnect/qcom/qcm2290.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c > index 96735800b13c..ba4cc08684d6 100644 > --- a/drivers/interconnect/qcom/qcm2290.c > +++ b/drivers/interconnect/qcom/qcm2290.c > @@ -164,7 +164,7 @@ static struct qcom_icc_node mas_snoc_bimc = { > .name = "mas_snoc_bimc", > .buswidth = 16, > .qos.ap_owned = true, > - .qos.qos_port = 2, > + .qos.qos_port = 6, > .qos.qos_mode = NOC_QOS_MODE_BYPASS, > .mas_rpm_id = 164, The mas_rpm_id is also wrong, I think it should be = 3. This looks wrongly copy pasted from BIMC_NRT. The qos_port on the other hand was copied from BIMC_RT. I wonder how that happened. :') Thanks, Stephan
On 26.03.2024 9:16 PM, Stephan Gerhold wrote: > On Tue, Mar 26, 2024 at 08:42:33PM +0100, Konrad Dybcio wrote: >> The value was wrong, resulting in misprogramming of the hardware. >> Fix it. >> >> Fixes: 1a14b1ac3935 ("interconnect: qcom: Add QCM2290 driver support") >> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> --- >> drivers/interconnect/qcom/qcm2290.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c >> index 96735800b13c..ba4cc08684d6 100644 >> --- a/drivers/interconnect/qcom/qcm2290.c >> +++ b/drivers/interconnect/qcom/qcm2290.c >> @@ -164,7 +164,7 @@ static struct qcom_icc_node mas_snoc_bimc = { >> .name = "mas_snoc_bimc", >> .buswidth = 16, >> .qos.ap_owned = true, >> - .qos.qos_port = 2, >> + .qos.qos_port = 6, >> .qos.qos_mode = NOC_QOS_MODE_BYPASS, >> .mas_rpm_id = 164, > > The mas_rpm_id is also wrong, I think it should be = 3. This looks > wrongly copy pasted from BIMC_NRT. The qos_port on the other hand was > copied from BIMC_RT. I wonder how that happened. :') Looks like you're right ;) I'll submit it in a separate series, preferably after this one.. Konrad
diff --git a/drivers/interconnect/qcom/qcm2290.c b/drivers/interconnect/qcom/qcm2290.c index 96735800b13c..ba4cc08684d6 100644 --- a/drivers/interconnect/qcom/qcm2290.c +++ b/drivers/interconnect/qcom/qcm2290.c @@ -164,7 +164,7 @@ static struct qcom_icc_node mas_snoc_bimc = { .name = "mas_snoc_bimc", .buswidth = 16, .qos.ap_owned = true, - .qos.qos_port = 2, + .qos.qos_port = 6, .qos.qos_mode = NOC_QOS_MODE_BYPASS, .mas_rpm_id = 164, .slv_rpm_id = -1,
The value was wrong, resulting in misprogramming of the hardware. Fix it. Fixes: 1a14b1ac3935 ("interconnect: qcom: Add QCM2290 driver support") Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> --- drivers/interconnect/qcom/qcm2290.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)