| Message ID | 20240323-gcc-arm-warnings-v1-1-0b45cc52f39e@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: Fix gcc warnings | expand |
On Sat Mar 23, 2024 at 11:41 AM CET, Ricardo Ribalda wrote: > Make sure that tegra20_vi_get_input_formats always assign a value for > yuv_input_format. > > Fix: > drivers/staging/media/tegra-video/tegra20.c:624:72: warning: ‘yuv_input_format’ may be used uninitialized [-Wmaybe-uninitialized] > > Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/staging/media/tegra-video/tegra20.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/media/tegra-video/tegra20.c b/drivers/staging/media/tegra-video/tegra20.c > index c25286772603c..c39b52d0e4447 100644 > --- a/drivers/staging/media/tegra-video/tegra20.c > +++ b/drivers/staging/media/tegra-video/tegra20.c > @@ -176,6 +176,7 @@ static void tegra20_vi_get_input_formats(struct tegra_vi_channel *chan, > (*yuv_input_format) = VI_INPUT_YUV_INPUT_FORMAT_YUYV; > break; > case MEDIA_BUS_FMT_YVYU8_2X8: > + default: This default seems rather arbitrary. Maybe we should follow the tegra20_vi_get_output_formats() and default to UYVY? Also, maybe follow the same scheme as that function (i.e. assign the default near the top of the function rather than add a default case)? Thierry > (*yuv_input_format) = VI_INPUT_YUV_INPUT_FORMAT_YVYU; > break; > }
diff --git a/drivers/staging/media/tegra-video/tegra20.c b/drivers/staging/media/tegra-video/tegra20.c index c25286772603c..c39b52d0e4447 100644 --- a/drivers/staging/media/tegra-video/tegra20.c +++ b/drivers/staging/media/tegra-video/tegra20.c @@ -176,6 +176,7 @@ static void tegra20_vi_get_input_formats(struct tegra_vi_channel *chan, (*yuv_input_format) = VI_INPUT_YUV_INPUT_FORMAT_YUYV; break; case MEDIA_BUS_FMT_YVYU8_2X8: + default: (*yuv_input_format) = VI_INPUT_YUV_INPUT_FORMAT_YVYU; break; }
Make sure that tegra20_vi_get_input_formats always assign a value for yuv_input_format. Fix: drivers/staging/media/tegra-video/tegra20.c:624:72: warning: ‘yuv_input_format’ may be used uninitialized [-Wmaybe-uninitialized] Signed-off-by: Ricardo Ribalda <ribalda@chromium.org> --- drivers/staging/media/tegra-video/tegra20.c | 1 + 1 file changed, 1 insertion(+)