diff mbox series

[v2,2/2] hwmon: lm70: fix links in doc and comments

Message ID 20240318154540.90613-3-five231003@gmail.com
State Accepted
Commit b18c01a4c82cf853add1255b51f7a4f1b3a39dc0
Headers show
Series lm70 and lm70llp doc link fixes | expand

Commit Message

Kousik Sanagavarapu March 18, 2024, 3:38 p.m. UTC
Update links in the documentation and in-code comments which point to
the datasheet.

The current links don't work because National Semiconductor (which is
the manufacturer of this board and lm70) has been a part of Texas
Instruments since 2011 and hence http://www.national.com/ doesn't work
anymore.

Fixes: e1a8e913f97e ("[PATCH] lm70: New hardware monitoring driver")
Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>
---
 Documentation/hwmon/lm70.rst | 2 +-
 drivers/hwmon/lm70.c         | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Guenter Roeck March 18, 2024, 6:11 p.m. UTC | #1
On Mon, Mar 18, 2024 at 09:08:35PM +0530, Kousik Sanagavarapu wrote:
> Update links in the documentation and in-code comments which point to
> the datasheet.
> 
> The current links don't work because National Semiconductor (which is
> the manufacturer of this board and lm70) has been a part of Texas
                      ^^^^^^^^^^

Is this a leftover from the other patch ? The lm70 driver supports
the LM70 chip, not a specific board.

Guenter
Kousik Sanagavarapu March 18, 2024, 6:29 p.m. UTC | #2
On Mon, Mar 18, 2024 at 11:11:29AM -0700, Guenter Roeck wrote:
> On Mon, Mar 18, 2024 at 09:08:35PM +0530, Kousik Sanagavarapu wrote:
> > Update links in the documentation and in-code comments which point to
> > the datasheet.
> > 
> > The current links don't work because National Semiconductor (which is
> > the manufacturer of this board and lm70) has been a part of Texas
>                       ^^^^^^^^^^
> 
> Is this a leftover from the other patch ? The lm70 driver supports
> the LM70 chip, not a specific board.

Yeah, it should be "the manufacturer of lm70".  Thanks for spotting.

Should I fix and resend this specific patch as v3 or would you edit it
while pulling?
Guenter Roeck March 18, 2024, 6:55 p.m. UTC | #3
On 3/18/24 11:29, Kousik Sanagavarapu wrote:
> On Mon, Mar 18, 2024 at 11:11:29AM -0700, Guenter Roeck wrote:
>> On Mon, Mar 18, 2024 at 09:08:35PM +0530, Kousik Sanagavarapu wrote:
>>> Update links in the documentation and in-code comments which point to
>>> the datasheet.
>>>
>>> The current links don't work because National Semiconductor (which is
>>> the manufacturer of this board and lm70) has been a part of Texas
>>                        ^^^^^^^^^^
>>
>> Is this a leftover from the other patch ? The lm70 driver supports
>> the LM70 chip, not a specific board.
> 
> Yeah, it should be "the manufacturer of lm70".  Thanks for spotting.
> 
> Should I fix and resend this specific patch as v3 or would you edit it
> while pulling?
> 

I'll edit it.

Thanks,
Guenter
Guenter Roeck March 20, 2024, 5:57 p.m. UTC | #4
On Mon, Mar 18, 2024 at 09:08:35PM +0530, Kousik Sanagavarapu wrote:
> Update links in the documentation and in-code comments which point to
> the datasheet.
> 
> The current links don't work because National Semiconductor (which is
> the manufacturer of this board and lm70) has been a part of Texas
> Instruments since 2011 and hence http://www.national.com/ doesn't work
> anymore.
> 
> Fixes: e1a8e913f97e ("[PATCH] lm70: New hardware monitoring driver")
> Signed-off-by: Kousik Sanagavarapu <five231003@gmail.com>

Applied to hwmon-next.

Please note that I'll push the branch after the commit window closed.

Thanks,
Guenter
diff mbox series

Patch

diff --git a/Documentation/hwmon/lm70.rst b/Documentation/hwmon/lm70.rst
index 11303a7e16a8..02ed60dddffb 100644
--- a/Documentation/hwmon/lm70.rst
+++ b/Documentation/hwmon/lm70.rst
@@ -5,7 +5,7 @@  Supported chips:
 
   * National Semiconductor LM70
 
-    Datasheet: http://www.national.com/pf/LM/LM70.html
+    Datasheet: https://www.ti.com/product/LM70
 
   * Texas Instruments TMP121/TMP123
 
diff --git a/drivers/hwmon/lm70.c b/drivers/hwmon/lm70.c
index c20a749fc7f2..481e4e1f8f4f 100644
--- a/drivers/hwmon/lm70.c
+++ b/drivers/hwmon/lm70.c
@@ -6,9 +6,9 @@ 
  * Copyright (C) 2006 Kaiwan N Billimoria <kaiwan@designergraphix.com>
  *
  * The LM70 communicates with a host processor via an SPI/Microwire Bus
- * interface. The complete datasheet is available at National's website
+ * interface. The complete datasheet is available at TI's website
  * here:
- * http://www.national.com/pf/LM/LM70.html
+ * https://www.ti.com/product/LM70
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt