diff mbox

[Linaro-uefi,v2,22/24] UpdateFdtDxe: Add GenericMemTestProtocol dependency

Message ID 1476796207-94336-23-git-send-email-heyi.guo@linaro.org
State Superseded
Headers show

Commit Message

gary guo Oct. 18, 2016, 1:10 p.m. UTC
The dependency should be added to FdtUpdateLib, but it could not be
added to UpdateFdtDxe when FdtUpdateLib becomes binary.

So this is a WA and can be removed after FdtUpdateLib open source.

Change-Id: If91a831110858d364857d9f0a901284ac868bfa5
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Heyi Guo <guoheyi@huawei.com>
---
 Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Leif Lindholm Oct. 27, 2016, 5:10 p.m. UTC | #1
On Tue, Oct 18, 2016 at 09:10:06PM +0800, Heyi Guo wrote:
> The dependency should be added to FdtUpdateLib, but it could not be
> added to UpdateFdtDxe when FdtUpdateLib becomes binary.
> 
> So this is a WA and can be removed after FdtUpdateLib open source.
> 
> Change-Id: If91a831110858d364857d9f0a901284ac868bfa5

Please drop the Change-Id for v3.
But apart from that:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Heyi Guo <guoheyi@huawei.com>
> ---
>  Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf
> index a0f0a9d..ccdcae7 100644
> --- a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf
> +++ b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf
> @@ -29,6 +29,7 @@
>  [Packages]
>    ArmPlatformPkg/ArmPlatformPkg.dec
>    MdePkg/MdePkg.dec
> +  MdeModulePkg/MdeModulePkg.dec
>    ArmPkg/ArmPkg.dec
>    OpenPlatformPkg/Chips/Hisilicon/HisiPkg.dec
>    EmbeddedPkg/EmbeddedPkg.dec
> @@ -58,5 +59,4 @@
>  
>  
>  [Depex]
> -TRUE
> -
> +  gEfiGenericMemTestProtocolGuid
> -- 
> 1.9.1
>
diff mbox

Patch

diff --git a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf
index a0f0a9d..ccdcae7 100644
--- a/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf
+++ b/Chips/Hisilicon/Drivers/UpdateFdtDxe/UpdateFdtDxe.inf
@@ -29,6 +29,7 @@ 
 [Packages]
   ArmPlatformPkg/ArmPlatformPkg.dec
   MdePkg/MdePkg.dec
+  MdeModulePkg/MdeModulePkg.dec
   ArmPkg/ArmPkg.dec
   OpenPlatformPkg/Chips/Hisilicon/HisiPkg.dec
   EmbeddedPkg/EmbeddedPkg.dec
@@ -58,5 +59,4 @@ 
 
 
 [Depex]
-TRUE
-
+  gEfiGenericMemTestProtocolGuid