| Message ID | 20240312183810.557768-6-peter.maydell@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | various: 7 minor Coverity fixes | expand |
On 12/3/24 19:38, Peter Maydell wrote: > There's no way for the macio_nvram device to report failure to write > data, but we can at least report it to the user with error_report() > as we do in other devices like xlnx-efuse. > > Spotted by Coverity. > > Resolves: Coverity CID 1507628 > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > hw/nvram/mac_nvram.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/hw/nvram/mac_nvram.c b/hw/nvram/mac_nvram.c index 5f9d16fb3e3..59277fbc776 100644 --- a/hw/nvram/mac_nvram.c +++ b/hw/nvram/mac_nvram.c @@ -48,7 +48,10 @@ static void macio_nvram_writeb(void *opaque, hwaddr addr, trace_macio_nvram_write(addr, value); s->data[addr] = value; if (s->blk) { - blk_pwrite(s->blk, addr, 1, &s->data[addr], 0); + if (blk_pwrite(s->blk, addr, 1, &s->data[addr], 0) < 0) { + error_report("%s: write of NVRAM data to backing store failed", + blk_name(s->blk)); + } } }
There's no way for the macio_nvram device to report failure to write data, but we can at least report it to the user with error_report() as we do in other devices like xlnx-efuse. Spotted by Coverity. Resolves: Coverity CID 1507628 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- hw/nvram/mac_nvram.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)