diff mbox series

[v2] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay

Message ID 20240308124129.7833-1-quic_vdadhani@quicinc.com
State Accepted
Commit 4286dbcecc3f8775852fee04c2ea8af265549af3
Headers show
Series [v2] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay | expand

Commit Message

Viken Dadhaniya March 8, 2024, 12:41 p.m. UTC
Currently we have auto suspend delay of 1s which is
very high and it takes long time to driver for runtime
suspend after use case is done.

Hence to optimize runtime PM ops, reduce auto suspend
delay to 100ms.

Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
---
v1 -> v2:
- Remove macro and add value inline.
- Link to v1: https://lore.kernel.org/linux-arm-msm/d784e46d-974d-4bf3-a2d3-491e7ad19701@linaro.org/T/
---
---
 drivers/slimbus/qcom-ngd-ctrl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Konrad Dybcio March 12, 2024, 12:15 a.m. UTC | #1
On 3/8/24 13:41, Viken Dadhaniya wrote:
> Currently we have auto suspend delay of 1s which is
> very high and it takes long time to driver for runtime
> suspend after use case is done.
> 
> Hence to optimize runtime PM ops, reduce auto suspend
> delay to 100ms.
> 
> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
> ---

Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
Srinivas Kandagatla April 11, 2024, 9:45 a.m. UTC | #2
On Fri, 08 Mar 2024 18:11:29 +0530, Viken Dadhaniya wrote:
> Currently we have auto suspend delay of 1s which is
> very high and it takes long time to driver for runtime
> suspend after use case is done.
> 
> Hence to optimize runtime PM ops, reduce auto suspend
> delay to 100ms.
> 
> [...]

Applied, thanks!

[1/1] slimbus: qcom-ngd-ctrl: Reduce auto suspend delay
      commit: 5e8e32f818138fff0087d7a9708806db49b650a4

Best regards,
diff mbox series

Patch

diff --git a/drivers/slimbus/qcom-ngd-ctrl.c b/drivers/slimbus/qcom-ngd-ctrl.c
index efeba8275a66..5e132273c6c4 100644
--- a/drivers/slimbus/qcom-ngd-ctrl.c
+++ b/drivers/slimbus/qcom-ngd-ctrl.c
@@ -81,7 +81,6 @@ 
 #define SLIM_USR_MC_DISCONNECT_PORT	0x2E
 #define SLIM_USR_MC_REPEAT_CHANGE_VALUE	0x0
 
-#define QCOM_SLIM_NGD_AUTOSUSPEND	MSEC_PER_SEC
 #define SLIM_RX_MSGQ_TIMEOUT_VAL	0x10000
 
 #define SLIM_LA_MGR	0xFF
@@ -1571,7 +1570,7 @@  static int qcom_slim_ngd_probe(struct platform_device *pdev)
 
 	platform_set_drvdata(pdev, ctrl);
 	pm_runtime_use_autosuspend(dev);
-	pm_runtime_set_autosuspend_delay(dev, QCOM_SLIM_NGD_AUTOSUSPEND);
+	pm_runtime_set_autosuspend_delay(dev, 100);
 	pm_runtime_set_suspended(dev);
 	pm_runtime_enable(dev);
 	pm_runtime_get_noresume(dev);