| Message ID | 20240307154510.3795380-3-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: xilinx: Massage xilinx_spi.h | expand |
On 3/7/24 16:43, Andy Shevchenko wrote: > xilinx_spi.h is mnissing inclusion and forward declaration, add them. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > include/linux/spi/xilinx_spi.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h > index fd6add419e94..4ba8f53ce570 100644 > --- a/include/linux/spi/xilinx_spi.h > +++ b/include/linux/spi/xilinx_spi.h > @@ -2,6 +2,10 @@ > #ifndef __LINUX_SPI_XILINX_SPI_H > #define __LINUX_SPI_XILINX_SPI_H > > +#include <linux/types.h> > + > +struct spi_board_info; > + > /** > * struct xspi_platform_data - Platform data of the Xilinx SPI driver > * @num_chipselect: Number of chip select by the IP. Likely correct but forget how to check it with tools. Thanks, Michal
On Fri, Mar 08, 2024 at 09:21:32AM +0100, Michal Simek wrote: > On 3/7/24 16:43, Andy Shevchenko wrote: > > xilinx_spi.h is mnissing inclusion and forward declaration, add them. ... > > diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h > > #define __LINUX_SPI_XILINX_SPI_H > > +#include <linux/types.h> > > + > > +struct spi_board_info; > > + > > /** > > * struct xspi_platform_data - Platform data of the Xilinx SPI driver > > * @num_chipselect: Number of chip select by the IP. > > Likely correct but forget how to check it with tools. I'm not sure which tools we have to check this. The types.h is needed for uXX The forward declaration for the pointer to the mentioned type. All this has been derived from reading the file.
On 3/8/24 14:56, Andy Shevchenko wrote: > On Fri, Mar 08, 2024 at 09:21:32AM +0100, Michal Simek wrote: >> On 3/7/24 16:43, Andy Shevchenko wrote: >>> xilinx_spi.h is mnissing inclusion and forward declaration, add them. > > ... > >>> diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h >>> #define __LINUX_SPI_XILINX_SPI_H >>> +#include <linux/types.h> >>> + >>> +struct spi_board_info; >>> + >>> /** >>> * struct xspi_platform_data - Platform data of the Xilinx SPI driver >>> * @num_chipselect: Number of chip select by the IP. >> >> Likely correct but forget how to check it with tools. > > I'm not sure which tools we have to check this. > > The types.h is needed for uXX > The forward declaration for the pointer to the mentioned type. > > All this has been derived from reading the file. No issue with it. But I am quite sure there was a tool which was able to find it out and report it. But forgot which one was it. M
On Fri, Mar 08, 2024 at 03:02:01PM +0100, Michal Simek wrote: > On 3/8/24 14:56, Andy Shevchenko wrote: > > On Fri, Mar 08, 2024 at 09:21:32AM +0100, Michal Simek wrote: > > > On 3/7/24 16:43, Andy Shevchenko wrote: > > > > xilinx_spi.h is mnissing inclusion and forward declaration, add them. ... > > > > diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h > > > > #define __LINUX_SPI_XILINX_SPI_H > > > > +#include <linux/types.h> > > > > + > > > > +struct spi_board_info; > > > > + > > > > /** > > > > * struct xspi_platform_data - Platform data of the Xilinx SPI driver > > > > * @num_chipselect: Number of chip select by the IP. > > > > > > Likely correct but forget how to check it with tools. > > > > I'm not sure which tools we have to check this. > > > > The types.h is needed for uXX > > The forward declaration for the pointer to the mentioned type. > > > > All this has been derived from reading the file. > > No issue with it. But I am quite sure there was a tool which was able to > find it out and report it. But forgot which one was it. You mean iwyu? If so, it needs a lot of tuning before being able to be used in Linux kernel.
On 3/8/24 16:00, Andy Shevchenko wrote: > On Fri, Mar 08, 2024 at 03:02:01PM +0100, Michal Simek wrote: >> On 3/8/24 14:56, Andy Shevchenko wrote: >>> On Fri, Mar 08, 2024 at 09:21:32AM +0100, Michal Simek wrote: >>>> On 3/7/24 16:43, Andy Shevchenko wrote: >>>>> xilinx_spi.h is mnissing inclusion and forward declaration, add them. > > ... > >>>>> diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h >>>>> #define __LINUX_SPI_XILINX_SPI_H >>>>> +#include <linux/types.h> >>>>> + >>>>> +struct spi_board_info; >>>>> + >>>>> /** >>>>> * struct xspi_platform_data - Platform data of the Xilinx SPI driver >>>>> * @num_chipselect: Number of chip select by the IP. >>>> >>>> Likely correct but forget how to check it with tools. >>> >>> I'm not sure which tools we have to check this. >>> >>> The types.h is needed for uXX >>> The forward declaration for the pointer to the mentioned type. >>> >>> All this has been derived from reading the file. >> >> No issue with it. But I am quite sure there was a tool which was able to >> find it out and report it. But forgot which one was it. > > You mean iwyu? If so, it needs a lot of tuning before being able to be used > in Linux kernel. > Acked-by; Michal Simek <michal.simek@amd.com> Thanks, Michal
diff --git a/include/linux/spi/xilinx_spi.h b/include/linux/spi/xilinx_spi.h index fd6add419e94..4ba8f53ce570 100644 --- a/include/linux/spi/xilinx_spi.h +++ b/include/linux/spi/xilinx_spi.h @@ -2,6 +2,10 @@ #ifndef __LINUX_SPI_XILINX_SPI_H #define __LINUX_SPI_XILINX_SPI_H +#include <linux/types.h> + +struct spi_board_info; + /** * struct xspi_platform_data - Platform data of the Xilinx SPI driver * @num_chipselect: Number of chip select by the IP.
xilinx_spi.h is mnissing inclusion and forward declaration, add them. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- include/linux/spi/xilinx_spi.h | 4 ++++ 1 file changed, 4 insertions(+)