| Message ID | 20240306093334.9321-4-changhuang.liang@starfivetech.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add ISP RAW for StarFive | expand |
On Wed, Mar 06, 2024 at 01:33:30AM -0800, Changhuang Liang wrote: > Sink rectangle will be valid for all source pads. > This commit message is just really unclear. What does "Sink rectangle set to ISP source pad" even mean? A better subject would probably be "staging: media: starfive: Use PAD_SINK instead of PAD_SRC for crop" But why are we making this change? It's not clear. regards, dan carpenter
diff --git a/drivers/staging/media/starfive/camss/stf-isp.c b/drivers/staging/media/starfive/camss/stf-isp.c index 6bab0ac23120..9b5745669fa6 100644 --- a/drivers/staging/media/starfive/camss/stf-isp.c +++ b/drivers/staging/media/starfive/camss/stf-isp.c @@ -88,7 +88,7 @@ static int isp_set_stream(struct v4l2_subdev *sd, int enable) fmt_t_src = &isp_dev->formats[STF_ISP_PAD_SRC]; fmt = v4l2_subdev_state_get_format(sd_state, STF_ISP_PAD_SINK); fmt_src = v4l2_subdev_state_get_format(sd_state, STF_ISP_PAD_SRC); - crop = v4l2_subdev_state_get_crop(sd_state, STF_ISP_PAD_SRC); + crop = v4l2_subdev_state_get_crop(sd_state, STF_ISP_PAD_SINK); src = stf_isp_g_index_by_mcode(fmt_t_src, fmt_src->code); if (enable) {
Sink rectangle will be valid for all source pads. Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com> --- drivers/staging/media/starfive/camss/stf-isp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)