| Message ID | 1476638243-10053-2-git-send-email-yamada.masahiro@socionext.com |
|---|---|
| State | New |
| Headers | show |
Hi Tom, 2016-10-17 5:12 GMT+09:00 Tom Rini <trini@konsulko.com>: > On Mon, Oct 17, 2016 at 02:17:23AM +0900, Masahiro Yamada wrote: >> This will make the log more readable. The log is not deterministic >> in case of parallel processing, though. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > I'm honestly ambivalent about this since single threaded is basically > never the case, right? Right. If you want to diff two logs, you need to pass -j1 option. But, my main motivation is not that. You will be able to find the log of boards you are interested in. For example, when some boards are listed in "suspicious results" at the end of conversion, you may want to check the log to see what happened. If the log is sorted *almost* alphabetically, it will be easier to jump there. -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
On Wed, Oct 19, 2016 at 01:23:24AM +0900, Masahiro Yamada wrote: > Hi Tom, > > 2016-10-17 5:12 GMT+09:00 Tom Rini <trini@konsulko.com>: > > On Mon, Oct 17, 2016 at 02:17:23AM +0900, Masahiro Yamada wrote: > >> This will make the log more readable. The log is not deterministic > >> in case of parallel processing, though. > >> > >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > > > I'm honestly ambivalent about this since single threaded is basically > > never the case, right? > > > Right. > If you want to diff two logs, you need to pass -j1 option. > > But, my main motivation is not that. > You will be able to find the log of boards you are interested in. > > For example, when some boards are listed in "suspicious results" > at the end of conversion, you may want to check the log > to see what happened. If the log is sorted *almost* alphabetically, > it will be easier to jump there. I'm still ambivalent. I 'less' the log and search doesn't care about order. And I try and fix one broken board at a time since it's often the case that N boards will have the same form of thinko. -- Tom _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
2016-10-19 4:25 GMT+09:00 Tom Rini <trini@konsulko.com>: > On Wed, Oct 19, 2016 at 01:23:24AM +0900, Masahiro Yamada wrote: >> Hi Tom, >> >> 2016-10-17 5:12 GMT+09:00 Tom Rini <trini@konsulko.com>: >> > On Mon, Oct 17, 2016 at 02:17:23AM +0900, Masahiro Yamada wrote: >> >> This will make the log more readable. The log is not deterministic >> >> in case of parallel processing, though. >> >> >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> > >> > I'm honestly ambivalent about this since single threaded is basically >> > never the case, right? >> >> >> Right. >> If you want to diff two logs, you need to pass -j1 option. >> >> But, my main motivation is not that. >> You will be able to find the log of boards you are interested in. >> >> For example, when some boards are listed in "suspicious results" >> at the end of conversion, you may want to check the log >> to see what happened. If the log is sorted *almost* alphabetically, >> it will be easier to jump there. > > I'm still ambivalent. I 'less' the log and search doesn't care about > order. And I try and fix one broken board at a time since it's often > the case that N boards will have the same form of thinko. OK, fine. Please drop this patch. I sent v2 only for 1/2. -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
diff --git a/tools/moveconfig.py b/tools/moveconfig.py index 67cf5f0..49cb1e2 100755 --- a/tools/moveconfig.py +++ b/tools/moveconfig.py @@ -1221,6 +1221,8 @@ def move_config(configs, options): else: defconfigs = get_all_defconfigs() + defconfigs.sort() + progress = Progress(len(defconfigs)) slots = Slots(configs, options, progress, reference_src_dir)
This will make the log more readable. The log is not deterministic in case of parallel processing, though. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- tools/moveconfig.py | 2 ++ 1 file changed, 2 insertions(+) -- 1.9.1 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot