diff mbox series

ACPI: resource: Add MAIBENBEN X577 to irq1_edge_low_force_override

Message ID CAAa5hjU-QV8LQtiNW5uuh_z1Gvge_q36LzmLqj7FiK7tT6JsOg@mail.gmail.com
State Accepted
Commit 021a67d096154893cd1d883c7be0097e2ee327fd
Headers show
Series ACPI: resource: Add MAIBENBEN X577 to irq1_edge_low_force_override | expand

Commit Message

Maxim Kudinov Feb. 23, 2024, 4:24 p.m. UTC
A known issue on some Zen laptops, keyboard stopped working due to commit
9946e39fe8d0 fael@kernel.org("ACPI: resource: skip IRQ override on AMD
Zen platforms")
on kernel 5.19.10.

The ACPI IRQ override is required for this board due to buggy DSDT, thus
adding the board vendor and name to irq1_edge_low_force_override fixes
the issue.

Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217394
Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com/
Tested-by: Maxim Trofimov <maxvereschagin@gmail.com>
Signed-off-by: Maxim Kudinov <m.kudinovv@gmail.com>
---
If you need more info (dmesg, dmidecode), then please let me know.

P.S. Sorry Rafael for sending it to you again, my email client was in
HTML mode, so
the email was rejected from the mailing list.
---
 drivers/acpi/resource.c | 7 +++++++
 1 file changed, 7 insertions(+)

--
2.43.2

Comments

Rafael J. Wysocki Feb. 27, 2024, 4:53 p.m. UTC | #1
On Fri, Feb 23, 2024 at 5:24 PM Uldyk <m.kudinovv@gmail.com> wrote:
>
> A known issue on some Zen laptops, keyboard stopped working due to commit
> 9946e39fe8d0 fael@kernel.org("ACPI: resource: skip IRQ override on AMD
> Zen platforms")
> on kernel 5.19.10.
>
> The ACPI IRQ override is required for this board due to buggy DSDT, thus
> adding the board vendor and name to irq1_edge_low_force_override fixes
> the issue.
>
> Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217394
> Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com/
> Tested-by: Maxim Trofimov <maxvereschagin@gmail.com>
> Signed-off-by: Maxim Kudinov <m.kudinovv@gmail.com>
> ---
> If you need more info (dmesg, dmidecode), then please let me know.
>
> P.S. Sorry Rafael for sending it to you again, my email client was in
> HTML mode, so
> the email was rejected from the mailing list.
> ---
>  drivers/acpi/resource.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> index dacad1d846c0..f681fd66d32b 100644
> --- a/drivers/acpi/resource.c
> +++ b/drivers/acpi/resource.c
> @@ -588,6 +588,13 @@ static const struct dmi_system_id
> irq1_edge_low_force_override[] = {
>                         DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
>                 },
>         },
> +       {
> +               /* MAIBENBEN X577 */
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "MAIBENBEN"),
> +                       DMI_MATCH(DMI_BOARD_NAME, "X577"),
> +               },
> +       },
>         { }
>  };
> --

Applied as 6.9 material, but:
(1) whitespace was all converted to spaces (please fix your email
client or use a different one to send patches),
(2) your S-o-b tag didn't match From:, so I used the name from the
former  for the latter.

Thanks!
Maxim Kudinov Feb. 27, 2024, 5:08 p.m. UTC | #2
Thank you!

Yeah, sorry about the formatting, I didn't know that gmail breaks it,
so most people are using git-send-email. It was my first patch.

Maxim.

On Tue, Feb 27, 2024 at 7:53 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Fri, Feb 23, 2024 at 5:24 PM Uldyk <m.kudinovv@gmail.com> wrote:
> >
> > A known issue on some Zen laptops, keyboard stopped working due to commit
> > 9946e39fe8d0 fael@kernel.org("ACPI: resource: skip IRQ override on AMD
> > Zen platforms")
> > on kernel 5.19.10.
> >
> > The ACPI IRQ override is required for this board due to buggy DSDT, thus
> > adding the board vendor and name to irq1_edge_low_force_override fixes
> > the issue.
> >
> > Fixes: 9946e39fe8d0 ("ACPI: resource: skip IRQ override on AMD Zen platforms")
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=217394
> > Link: https://lore.kernel.org/linux-acpi/20231006123304.32686-1-hdegoede@redhat.com/
> > Tested-by: Maxim Trofimov <maxvereschagin@gmail.com>
> > Signed-off-by: Maxim Kudinov <m.kudinovv@gmail.com>
> > ---
> > If you need more info (dmesg, dmidecode), then please let me know.
> >
> > P.S. Sorry Rafael for sending it to you again, my email client was in
> > HTML mode, so
> > the email was rejected from the mailing list.
> > ---
> >  drivers/acpi/resource.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
> > index dacad1d846c0..f681fd66d32b 100644
> > --- a/drivers/acpi/resource.c
> > +++ b/drivers/acpi/resource.c
> > @@ -588,6 +588,13 @@ static const struct dmi_system_id
> > irq1_edge_low_force_override[] = {
> >                         DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
> >                 },
> >         },
> > +       {
> > +               /* MAIBENBEN X577 */
> > +               .matches = {
> > +                       DMI_MATCH(DMI_SYS_VENDOR, "MAIBENBEN"),
> > +                       DMI_MATCH(DMI_BOARD_NAME, "X577"),
> > +               },
> > +       },
> >         { }
> >  };
> > --
>
> Applied as 6.9 material, but:
> (1) whitespace was all converted to spaces (please fix your email
> client or use a different one to send patches),
> (2) your S-o-b tag didn't match From:, so I used the name from the
> former  for the latter.
>
> Thanks!
diff mbox series

Patch

diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c
index dacad1d846c0..f681fd66d32b 100644
--- a/drivers/acpi/resource.c
+++ b/drivers/acpi/resource.c
@@ -588,6 +588,13 @@  static const struct dmi_system_id
irq1_edge_low_force_override[] = {
                        DMI_MATCH(DMI_BOARD_NAME, "GM5RGEE0016COM"),
                },
        },
+       {
+               /* MAIBENBEN X577 */
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "MAIBENBEN"),
+                       DMI_MATCH(DMI_BOARD_NAME, "X577"),
+               },
+       },
        { }
 };