diff mbox series

[v2,02/27] tests/tcg: bump TCG test timeout to 120s

Message ID 20240223162202.1936541-3-alex.bennee@linaro.org
State Superseded
Headers show
Series maintainer updates for 9.0 pre-PR (tests, plugin register support) | expand

Commit Message

Alex Bennée Feb. 23, 2024, 4:21 p.m. UTC
This is less than ideal but easier than making sure we get all the
iterations of the memory test. Update the comment accordingly.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/tcg/Makefile.target | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

Thomas Huth Feb. 23, 2024, 7:17 p.m. UTC | #1
On 23/02/2024 17.21, Alex Bennée wrote:
> This is less than ideal but easier than making sure we get all the
> iterations of the memory test. Update the comment accordingly.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/tcg/Makefile.target | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
> index 8cf65f68dd8..a4c25908fb7 100644
> --- a/tests/tcg/Makefile.target
> +++ b/tests/tcg/Makefile.target
> @@ -93,12 +93,9 @@ QEMU_OPTS=
>   
>   
>   # If TCG debugging, or TCI is enabled things are a lot slower
> -# ??? Makefile no longer has any indication that TCI is enabled,
> -# but for the record:
> -#   15s    original default
> -#   60s    with --enable-debug
> -#   90s    with --enable-tcg-interpreter
> -TIMEOUT=90
> +# so we have to set our timeout for that. The current worst case
> +# offender is the system memory test running under TCI.
> +TIMEOUT=120
>   
>   ifeq ($(filter %-softmmu, $(TARGET)),)
>   # The order we include is important. We include multiarch first and

Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/tests/tcg/Makefile.target b/tests/tcg/Makefile.target
index 8cf65f68dd8..a4c25908fb7 100644
--- a/tests/tcg/Makefile.target
+++ b/tests/tcg/Makefile.target
@@ -93,12 +93,9 @@  QEMU_OPTS=
 
 
 # If TCG debugging, or TCI is enabled things are a lot slower
-# ??? Makefile no longer has any indication that TCI is enabled,
-# but for the record:
-#   15s    original default
-#   60s    with --enable-debug
-#   90s    with --enable-tcg-interpreter
-TIMEOUT=90
+# so we have to set our timeout for that. The current worst case
+# offender is the system memory test running under TCI.
+TIMEOUT=120
 
 ifeq ($(filter %-softmmu, $(TARGET)),)
 # The order we include is important. We include multiarch first and