diff mbox

[API-NEXT,06/14] api: shm: add flag to lock memory

Message ID 1475836517-60484-7-git-send-email-christophe.milard@linaro.org
State Superseded
Headers show

Commit Message

Christophe Milard Oct. 7, 2016, 10:35 a.m. UTC
The ODP_SHM_LOCK flag is created: when set (at odp_shm_reserve()),
this flag locks the reserved memory (prevent swapping)

Signed-off-by: Christophe Milard <christophe.milard@linaro.org>

---
 include/odp/api/spec/shared_memory.h | 1 +
 1 file changed, 1 insertion(+)

-- 
2.7.4

Comments

Maxim Uvarov Oct. 7, 2016, 10:39 a.m. UTC | #1
On 10/07/16 13:35, Christophe Milard wrote:
> The ODP_SHM_LOCK flag is created: when set (at odp_shm_reserve()),

> this flag locks the reserved memory (prevent swapping)

>

> Signed-off-by: Christophe Milard <christophe.milard@linaro.org>

> ---

>   include/odp/api/spec/shared_memory.h | 1 +

>   1 file changed, 1 insertion(+)

>

> diff --git a/include/odp/api/spec/shared_memory.h b/include/odp/api/spec/shared_memory.h

> index fefb5d6..fe683d4 100644

> --- a/include/odp/api/spec/shared_memory.h

> +++ b/include/odp/api/spec/shared_memory.h

> @@ -48,6 +48,7 @@ extern "C" {

>   #define ODP_SHM_SW_ONLY		0x1 /**< Application SW only, no HW access   */

>   #define ODP_SHM_PROC		0x2 /**< Share with external processes       */

>   #define ODP_SHM_SINGLE_VA	0x4 /**< guarantee unique addr on all threads*/

> +#define ODP_SHM_LOCK		0x8 /**< prevent swapping this memory        */

>   

this patch also should change no create to 16:

#define _ODP_SHM_PROC_NOCREAT 0x4
>   /**

>    * Shared memory block info
Christophe Milard Oct. 7, 2016, 11:25 a.m. UTC | #2
No... The whole odp_shm_internal.h contents should be removed: There
is no reason for all this to exist: IPC is poking into shm internal,
and it should not...
But then I get a compilation problem of course... :-(



On 7 October 2016 at 12:39, Maxim Uvarov <maxim.uvarov@linaro.org> wrote:
> On 10/07/16 13:35, Christophe Milard wrote:

>>

>> The ODP_SHM_LOCK flag is created: when set (at odp_shm_reserve()),

>> this flag locks the reserved memory (prevent swapping)

>>

>> Signed-off-by: Christophe Milard <christophe.milard@linaro.org>

>> ---

>>   include/odp/api/spec/shared_memory.h | 1 +

>>   1 file changed, 1 insertion(+)

>>

>> diff --git a/include/odp/api/spec/shared_memory.h

>> b/include/odp/api/spec/shared_memory.h

>> index fefb5d6..fe683d4 100644

>> --- a/include/odp/api/spec/shared_memory.h

>> +++ b/include/odp/api/spec/shared_memory.h

>> @@ -48,6 +48,7 @@ extern "C" {

>>   #define ODP_SHM_SW_ONLY               0x1 /**< Application SW only, no

>> HW access   */

>>   #define ODP_SHM_PROC          0x2 /**< Share with external processes

>> */

>>   #define ODP_SHM_SINGLE_VA     0x4 /**< guarantee unique addr on all

>> threads*/

>> +#define ODP_SHM_LOCK           0x8 /**< prevent swapping this memory

>> */

>>

>

> this patch also should change no create to 16:

>

> #define _ODP_SHM_PROC_NOCREAT 0x4

>

>>   /**

>>    * Shared memory block info

>

>
diff mbox

Patch

diff --git a/include/odp/api/spec/shared_memory.h b/include/odp/api/spec/shared_memory.h
index fefb5d6..fe683d4 100644
--- a/include/odp/api/spec/shared_memory.h
+++ b/include/odp/api/spec/shared_memory.h
@@ -48,6 +48,7 @@  extern "C" {
 #define ODP_SHM_SW_ONLY		0x1 /**< Application SW only, no HW access   */
 #define ODP_SHM_PROC		0x2 /**< Share with external processes       */
 #define ODP_SHM_SINGLE_VA	0x4 /**< guarantee unique addr on all threads*/
+#define ODP_SHM_LOCK		0x8 /**< prevent swapping this memory        */
 
 /**
  * Shared memory block info