| Message ID | 20240212-expresswire-deps-v1-2-685ad10cd693@skole.hr |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leds: expresswire: Fix dependencies | expand |
On Mon, Feb 12, 2024 at 09:03:26PM +0100, Duje Mihanović wrote: > The ExpressWire library does not depend on NEW_LEDS and selecting it > from a subsystem other than LEDs may cause Kconfig warnings: > > WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE > Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y] > Selected by [y]: > - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y] > > Move it out of the "if NEW_LEDS" block to allow selection from other > subsystems (in particular backlight) without raising this warning. > > Link: https://lore.kernel.org/20240212111819.936815-1-arnd@kernel.org > Reported-by: Arnd Bergmann <arnd@arndb.de> > Suggested-by: Daniel Thompson <daniel.thompson@linaro.org> > Fixes: 25ae5f5f4168 ("leds: Introduce ExpressWire library") > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Daniel.
On Thursday, February 15, 2024 12:48:31 PM CET Daniel Thompson wrote: > On Mon, Feb 12, 2024 at 09:03:26PM +0100, Duje Mihanović wrote: ... > > Link: https://lore.kernel.org/20240212111819.936815-1-arnd@kernel.org > > Reported-by: Arnd Bergmann <arnd@arndb.de> > > Suggested-by: Daniel Thompson <daniel.thompson@linaro.org> > > Fixes: 25ae5f5f4168 ("leds: Introduce ExpressWire library") > > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > > Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> I must note that checkpatch actually complains about this patch (I may have hit send too early): 0002-leds-expresswire-don-t-depend-on-NEW_LEDS.patch ---------------------------------------------------- WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report #21: Reported-by: Arnd Bergmann <arnd@arndb.de> Suggested-by: Daniel Thompson <daniel.thompson@linaro.org> total: 0 errors, 1 warnings, 22 lines checked Could that Link: above be transformed into a Closes:? Regards,
diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig index 52328d295b4e..66998b938ed3 100644 --- a/drivers/leds/Kconfig +++ b/drivers/leds/Kconfig @@ -6,6 +6,12 @@ config LEDS_GPIO_REGISTER As this function is used by arch code it must not be compiled as a module. +# This library does not depend on NEW_LEDS and must be independent so it can be +# selected from other subsystems (specifically backlight). +config LEDS_EXPRESSWIRE + bool + depends on GPIOLIB + menuconfig NEW_LEDS bool "LED Support" help @@ -186,10 +192,6 @@ config LEDS_EL15203000 To compile this driver as a module, choose M here: the module will be called leds-el15203000. -config LEDS_EXPRESSWIRE - bool - depends on GPIOLIB - config LEDS_TURRIS_OMNIA tristate "LED support for CZ.NIC's Turris Omnia" depends on LEDS_CLASS_MULTICOLOR
The ExpressWire library does not depend on NEW_LEDS and selecting it from a subsystem other than LEDs may cause Kconfig warnings: WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE Depends on [n]: NEW_LEDS [=n] && GPIOLIB [=y] Selected by [y]: - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y] Move it out of the "if NEW_LEDS" block to allow selection from other subsystems (in particular backlight) without raising this warning. Link: https://lore.kernel.org/20240212111819.936815-1-arnd@kernel.org Reported-by: Arnd Bergmann <arnd@arndb.de> Suggested-by: Daniel Thompson <daniel.thompson@linaro.org> Fixes: 25ae5f5f4168 ("leds: Introduce ExpressWire library") Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> --- drivers/leds/Kconfig | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)