| Message ID | 20240209094651.5379-1-niko.mauno@vaisala.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/2] usb: core: Amend initial authorized_default value | expand |
On Fri, Feb 09, 2024 at 11:46:50AM +0200, niko.mauno@vaisala.com wrote: > From: Niko Mauno <niko.mauno@vaisala.com> > > Since the wireless USB implementation has been removed and since the > behavior with authorized_default values -1 and 1 is now effectively > same, change the initial value to latter in order to stop using the > leftover value. The former value can still be passed as a module > parameter to retain backwards compatibility. > > Signed-off-by: Niko Mauno <niko.mauno@vaisala.com> > --- > drivers/usb/core/hcd.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Isn't this series already in my tree? confused, greg k-h
On 9.2.2024 15.34, Greg KH wrote: > On Fri, Feb 09, 2024 at 02:39:01PM +0200, Niko Mauno wrote: >> On 9.2.2024 12.47, Greg KH wrote: >>> On Fri, Feb 09, 2024 at 11:46:50AM +0200, niko.mauno@vaisala.com wrote: >>>> From: Niko Mauno <niko.mauno@vaisala.com> >>>> >>>> Since the wireless USB implementation has been removed and since the >>>> behavior with authorized_default values -1 and 1 is now effectively >>>> same, change the initial value to latter in order to stop using the >>>> leftover value. The former value can still be passed as a module >>>> parameter to retain backwards compatibility. >>>> >>>> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com> >>>> --- >>>> drivers/usb/core/hcd.c | 6 ++---- >>>> 1 file changed, 2 insertions(+), 4 deletions(-) >>> >>> Isn't this series already in my tree? >>> >>> confused, >>> >>> greg k-h >> >> Hi Greg, apologies for any confusion I may have caused, >> >> Geert requested some further clarification in the new Kconfig help section, >> please see: >> https://marc.info/?l=linux-usb&m=170747246528305&w=2 > > Great, but I can't take patches that are already in my tree, right? > > Please submit a new one on top of what I currently have. > >> (There shouldn't be any functional change introduced between v2 and v3) > > That always needs to be listed, as my bot says, otherwise we have no > idea what is going on here. Remember, some of us get 1000+ emails a day > to do something with (review, apply, delete, ignore...) > > thanks, > > greg k-h Thanks, submitted as new patch against usb-next. -Niko
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c index 12b6dfeaf658..9aa5e6bf9b9d 100644 --- a/drivers/usb/core/hcd.c +++ b/drivers/usb/core/hcd.c @@ -357,12 +357,10 @@ static const u8 ss_rh_config_descriptor[] = { #define USB_AUTHORIZE_ALL 1 #define USB_AUTHORIZE_INTERNAL 2 -static int authorized_default = USB_AUTHORIZE_WIRED; +static int authorized_default = USB_AUTHORIZE_ALL; module_param(authorized_default, int, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(authorized_default, - "Default USB device authorization: 0 is not authorized, 1 is " - "authorized, 2 is authorized for internal devices, -1 is " - "authorized (default, same as 1)"); + "Default USB device authorization: 0 is not authorized, 1 is authorized (default), 2 is authorized for internal devices, -1 is authorized (same as 1)"); /*-------------------------------------------------------------------------*/ /**