| Message ID | 20240209151221.3967655-1-caleb.connolly@linaro.org |
|---|---|
| State | Accepted |
| Commit | 22f391e8be11986bae824509470cf11e7bac31b0 |
| Headers | show |
| Series | button: qcom-pmic: demote "unknown button" message to debug | expand |
On Fri, 9 Feb 2024 at 20:44, Caleb Connolly <caleb.connolly@linaro.org> wrote: > > This message isn't an error (there can be a watchdog subnode for example) > but it shouldn't be printed unless this driver is being debugged. Demote > it to a debug print. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > drivers/button/button-qcom-pmic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Sumit Garg <sumit.garg@linaro.org> -Sumit > diff --git a/drivers/button/button-qcom-pmic.c b/drivers/button/button-qcom-pmic.c > index 34a976d1e6c6..e6702139ca2d 100644 > --- a/drivers/button/button-qcom-pmic.c > +++ b/drivers/button/button-qcom-pmic.c > @@ -133,7 +133,7 @@ static int button_qcom_pmic_bind(struct udevice *parent) > } else if (NODE_IS_RESIN(node)) { > uc_plat->label = "vol_down"; > } else { > - printf("Unknown button node '%s' should be 'pwrkey' or 'resin'\n", > + debug("Unknown button node '%s' should be 'pwrkey' or 'resin'\n", > ofnode_get_name(node)); > device_unbind(dev); > } > -- > 2.43.0 >
On 09/02/2024 16:11, Caleb Connolly wrote: > This message isn't an error (there can be a watchdog subnode for example) > but it shouldn't be printed unless this driver is being debugged. Demote > it to a debug print. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- > drivers/button/button-qcom-pmic.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/button/button-qcom-pmic.c b/drivers/button/button-qcom-pmic.c > index 34a976d1e6c6..e6702139ca2d 100644 > --- a/drivers/button/button-qcom-pmic.c > +++ b/drivers/button/button-qcom-pmic.c > @@ -133,7 +133,7 @@ static int button_qcom_pmic_bind(struct udevice *parent) > } else if (NODE_IS_RESIN(node)) { > uc_plat->label = "vol_down"; > } else { > - printf("Unknown button node '%s' should be 'pwrkey' or 'resin'\n", > + debug("Unknown button node '%s' should be 'pwrkey' or 'resin'\n", > ofnode_get_name(node)); > device_unbind(dev); > } Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
diff --git a/drivers/button/button-qcom-pmic.c b/drivers/button/button-qcom-pmic.c index 34a976d1e6c6..e6702139ca2d 100644 --- a/drivers/button/button-qcom-pmic.c +++ b/drivers/button/button-qcom-pmic.c @@ -133,7 +133,7 @@ static int button_qcom_pmic_bind(struct udevice *parent) } else if (NODE_IS_RESIN(node)) { uc_plat->label = "vol_down"; } else { - printf("Unknown button node '%s' should be 'pwrkey' or 'resin'\n", + debug("Unknown button node '%s' should be 'pwrkey' or 'resin'\n", ofnode_get_name(node)); device_unbind(dev); }
This message isn't an error (there can be a watchdog subnode for example) but it shouldn't be printed unless this driver is being debugged. Demote it to a debug print. Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> --- drivers/button/button-qcom-pmic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)