| Message ID | 20240209150039.22211-3-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | system/memory: Trivial fixes | expand |
On Fri, 9 Feb 2024 at 15:02, Philippe Mathieu-Daudé <philmd@linaro.org> wrote: > > Include "exec/memory.h" in order to avoid: > > monitor/hmp-cmds-target.c:263:10: error: call to undeclared function 'memory_region_is_ram'; > ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] > if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) { > ^ > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > monitor/hmp-cmds-target.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c > index d9fbcac08d..9338ae8440 100644 > --- a/monitor/hmp-cmds-target.c > +++ b/monitor/hmp-cmds-target.c > @@ -25,6 +25,7 @@ > #include "qemu/osdep.h" > #include "disas/disas.h" > #include "exec/address-spaces.h" > +#include "exec/memory.h" > #include "monitor/hmp-target.h" > #include "monitor/monitor-internal.h" > #include "qapi/error.h" > -- > 2.41.0 Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c index d9fbcac08d..9338ae8440 100644 --- a/monitor/hmp-cmds-target.c +++ b/monitor/hmp-cmds-target.c @@ -25,6 +25,7 @@ #include "qemu/osdep.h" #include "disas/disas.h" #include "exec/address-spaces.h" +#include "exec/memory.h" #include "monitor/hmp-target.h" #include "monitor/monitor-internal.h" #include "qapi/error.h"
Include "exec/memory.h" in order to avoid: monitor/hmp-cmds-target.c:263:10: error: call to undeclared function 'memory_region_is_ram'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] if (!memory_region_is_ram(mrs.mr) && !memory_region_is_romd(mrs.mr)) { ^ Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- monitor/hmp-cmds-target.c | 1 + 1 file changed, 1 insertion(+)