| Message ID | 20240206171245.2421538-1-colin.i.king@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [next,V2] mmc: wbsd: remove redundant assignment to variable id and id check | expand |
On Tue, 6 Feb 2024 at 18:12, Colin Ian King <colin.i.king@gmail.com> wrote: > > The variable id is being initialized with a value that is never > read, it is being re-assigned later on. The initialization is > redundant and can be removed. > > As noted by Ulf Hansson the unknown hardware check id != 0xFFFF > is also redundant and can be removed too. > > Cleans up clang scan build warning: > drivers/mmc/host/wbsd.c:1287:4: warning: Value stored to 'id' > is never read [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> I had a second look and it's not entirely clear what the check if (id != 0xFFFF) is used for. Therefore, I suggest we simply keep that check, to be safe. That said, I decided to pick your patch v1 for next, thanks! Kind regards Uffe > --- > V2: As suggested by Ulf Hansson, also remove the redundant > hardware check for id != 0xFFFF. > --- > drivers/mmc/host/wbsd.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c > index 001a468bc149..4b32421d9f6d 100644 > --- a/drivers/mmc/host/wbsd.c > +++ b/drivers/mmc/host/wbsd.c > @@ -1284,8 +1284,6 @@ static int wbsd_scan(struct wbsd_host *host) > continue; > > for (j = 0; j < ARRAY_SIZE(unlock_codes); j++) { > - id = 0xFFFF; > - > host->config = config_ports[i]; > host->unlock_code = unlock_codes[j]; > > @@ -1306,11 +1304,6 @@ static int wbsd_scan(struct wbsd_host *host) > return 0; > } > } > - > - if (id != 0xFFFF) { > - DBG("Unknown hardware (id %x) found at %x\n", > - id, config_ports[i]); > - } > } > > release_region(config_ports[i], 2); > -- > 2.39.2 >
diff --git a/drivers/mmc/host/wbsd.c b/drivers/mmc/host/wbsd.c index 001a468bc149..4b32421d9f6d 100644 --- a/drivers/mmc/host/wbsd.c +++ b/drivers/mmc/host/wbsd.c @@ -1284,8 +1284,6 @@ static int wbsd_scan(struct wbsd_host *host) continue; for (j = 0; j < ARRAY_SIZE(unlock_codes); j++) { - id = 0xFFFF; - host->config = config_ports[i]; host->unlock_code = unlock_codes[j]; @@ -1306,11 +1304,6 @@ static int wbsd_scan(struct wbsd_host *host) return 0; } } - - if (id != 0xFFFF) { - DBG("Unknown hardware (id %x) found at %x\n", - id, config_ports[i]); - } } release_region(config_ports[i], 2);
The variable id is being initialized with a value that is never read, it is being re-assigned later on. The initialization is redundant and can be removed. As noted by Ulf Hansson the unknown hardware check id != 0xFFFF is also redundant and can be removed too. Cleans up clang scan build warning: drivers/mmc/host/wbsd.c:1287:4: warning: Value stored to 'id' is never read [deadcode.DeadStores] Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- V2: As suggested by Ulf Hansson, also remove the redundant hardware check for id != 0xFFFF. --- drivers/mmc/host/wbsd.c | 7 ------- 1 file changed, 7 deletions(-)