diff mbox series

Fix disabling of year 2038 support on 32-bit hosts by default

Message ID 20240206205524.71766-1-thiago.bauermann@linaro.org
State New
Headers show
Series Fix disabling of year 2038 support on 32-bit hosts by default | expand

Commit Message

Thiago Jung Bauermann Feb. 6, 2024, 8:55 p.m. UTC 
Commit e5f2f7d901ee ("Disable year 2038 support on 32-bit hosts by
default") fixed a mismatch between 64-bit time_t in GDB and system headers
and 32-bit time_t in BFD.

However, since commit 862776f26a59 ("Finalized intl-update patches")
gnulib's year 2038 support has been accidentally re-enabled — causing
problems for 32-bit hosts again.  The commit split baseargs into
{h,b}baseargs, but this hasn't been done for the code that handles
--disable-year2038.

This patch restores the intended behaviour.  With this change, the number
of unexpected core files goes from 18 to 4.

Tested on armv8l-linux-gnueabihf.

Approved-By: Luis Machado <luis.machado@arm.com>
---

Hello,

Yesterday I committed this patch to the binutils-gdb repo. Since the
toplevel configure should be in sync between the 2 repos, could someone
please commit it to the gcc one? I don't have commit access.

 configure    | 3 ++-
 configure.ac | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)
diff mbox series

Patch

diff --git a/configure b/configure
index 874966fb9f09..1da0e67c28fa 100755
--- a/configure
+++ b/configure
@@ -10301,7 +10301,8 @@  hbaseargs="$hbaseargs --disable-option-checking"
 tbaseargs="$tbaseargs --disable-option-checking"
 
 if test "$enable_year2038" = no; then
-  baseargs="$baseargs --disable-year2038"
+  bbaseargs="$bbaseargs --disable-year2038"
+  hbaseargs="$hbaseargs --disable-year2038"
   tbaseargs="$tbaseargs --disable-year2038"
 fi
 
diff --git a/configure.ac b/configure.ac
index 4f34004a0726..fa508a0612a3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3420,7 +3420,8 @@  hbaseargs="$hbaseargs --disable-option-checking"
 tbaseargs="$tbaseargs --disable-option-checking"
 
 if test "$enable_year2038" = no; then
-  baseargs="$baseargs --disable-year2038"
+  bbaseargs="$bbaseargs --disable-year2038"
+  hbaseargs="$hbaseargs --disable-year2038"
   tbaseargs="$tbaseargs --disable-year2038"
 fi