| Message ID | 20240204-bus_cleanup-gpio-v1-1-82d91b4ee1de@marliere.net |
|---|---|
| State | Accepted |
| Commit | a875746f603b86134bd1924b7289fc3542fd45e7 |
| Headers | show |
| Series | gpio: gpiolib: make gpio_bus_type const | expand |
On Sun, Feb 04, 2024 at 07:34:43PM +0100, Bartosz Golaszewski wrote: > On Sun, Feb 4, 2024 at 5:29 PM Ricardo B. Marliere <ricardo@marliere.net> wrote: > > > > Now that the driver core can properly handle constant struct bus_type, > > move the gpio_bus_type variable to be a constant structure as well, > > placing it into read-only memory which can not be modified at runtime. > > > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> > > --- > > drivers/gpio/gpiolib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > index d50a786f8176..24d046268a01 100644 > > --- a/drivers/gpio/gpiolib.c > > +++ b/drivers/gpio/gpiolib.c > > @@ -63,7 +63,7 @@ static int gpio_bus_match(struct device *dev, struct device_driver *drv) > > return 1; > > } > > > > -static struct bus_type gpio_bus_type = { > > +static const struct bus_type gpio_bus_type = { > > .name = "gpio", > > .match = gpio_bus_match, > > }; > > > > --- > > base-commit: 3eac8bbed22e940ac1645a884f221bef408f675c > > change-id: 20240204-bus_cleanup-gpio-57eea8d32a5a > > > > Best regards, > > -- > > Ricardo B. Marliere <ricardo@marliere.net> > > > > Ha! Does the same work now for struct device_type? Very much so, please feel free to do so, that's next on my list of things to do for the tree. greg k-h
On Sun, Feb 04, 2024 at 01:29:42PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the gpio_bus_type variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index d50a786f8176..24d046268a01 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -63,7 +63,7 @@ static int gpio_bus_match(struct device *dev, struct device_driver *drv) return 1; } -static struct bus_type gpio_bus_type = { +static const struct bus_type gpio_bus_type = { .name = "gpio", .match = gpio_bus_match, };
Now that the driver core can properly handle constant struct bus_type, move the gpio_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> --- drivers/gpio/gpiolib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 3eac8bbed22e940ac1645a884f221bef408f675c change-id: 20240204-bus_cleanup-gpio-57eea8d32a5a Best regards,